From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest] [PATCH] Specify the system UUID for VM Date: Wed, 29 Jul 2009 09:48:41 -0300 Message-ID: <6ac58f4f0907290548h70671dcerfbfa6dbe7213b93c@mail.gmail.com> References: <6ac58f4f0907290536m1f7895f2p74d07c17837f8bb1@mail.gmail.com> <2030247853.1166561248871613315.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: autotest@test.kernel.org, Avi Kivity , kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mail-qy0-f196.google.com ([209.85.221.196]:43096 "EHLO mail-qy0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729AbZG2Msm convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2009 08:48:42 -0400 Received: by qyk34 with SMTP id 34so128348qyk.33 for ; Wed, 29 Jul 2009 05:48:41 -0700 (PDT) In-Reply-To: <2030247853.1166561248871613315.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 29, 2009 at 9:46 AM, Michael Goldish w= rote: > > ----- "Lucas Meneghel Rodrigues" wrote: > >> On Wed, Jul 29, 2009 at 9:18 AM, Avi Kivity wrote: >> > On 07/16/2009 01:26 PM, Yolkfull Chow wrote: >> >> >> >> Signed-off-by: Yolkfull Chow >> >> --- >> >> =A0client/tests/kvm/kvm_vm.py | =A0 11 +++++++++++ >> >> =A01 files changed, 11 insertions(+), 0 deletions(-) >> >> >> >> diff --git a/client/tests/kvm/kvm_vm.py >> b/client/tests/kvm/kvm_vm.py >> >> index 503f636..895049e 100644 >> >> --- a/client/tests/kvm/kvm_vm.py >> >> +++ b/client/tests/kvm/kvm_vm.py >> >> @@ -113,6 +113,13 @@ class VM: >> >> =A0 =A0 =A0 =A0 =A0self.qemu_path =3D qemu_path >> >> =A0 =A0 =A0 =A0 =A0self.image_dir =3D image_dir >> >> =A0 =A0 =A0 =A0 =A0self.iso_dir =3D iso_dir >> >> + >> >> + =A0 =A0 =A0 =A0if params.get("uuid"): >> >> + =A0 =A0 =A0 =A0 =A0 =A0if params.get("uuid") =3D=3D "random": >> >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0uuid =3D os.popen("cat >> >> /proc/sys/kernel/random/uuid").readline() >> >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0self.uuid =3D uuid.strip() >> >> >> > >> > instead of os.popen("cat ..."), you can open the file directly: >> > >> > =A0 uuid =3D file('/proc/.../uuid').readline() >> >> Oooops... I didn't notice this little issue. Will make a quick patch >> to change it, thanks Avi! > > I think I already commented on this and Yolkfull posted a new patch, > and that patch is the one that got applied. =A0That's what I see in m= y > local tree anyway. Yep, I over-reacted :)