From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B292744D; Sat, 28 Dec 2024 19:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735414095; cv=none; b=rlzgu8HbAchGabDdIFuHwiZQkGSnZkCBRrhGPXLPxHdvZcq0BPP7W84sLypjHwf50MTsWV+PFeU6TRme82LJV3dW1tjpUOwtkJ4GHmHkCTJJRZhlvw02pb/M/u3mJgYzRFJORJnK6pfGpOA9/wyC9+INFqcyvCO+2sjKE5gH7Mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735414095; c=relaxed/simple; bh=VSUk2RevzgoLpoKkPtxfiydxyc1+Qk/NEc9zjGax7Xk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P9ZvzaK5I8aGnSHHzO8l78JQx4uBNWFk5xBa/txVpHLhrd6dggDdP3PWcpk4y3pk9YnAumcp5D8fcLaar4bKtT/oNwqsbWUAB96mWmUGyDlQnwVlNannDb9eX0c6nmfjRBNPUTKrAiWRbkbawjrZBUYJZBST9p2bCSAu6EcDm3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p97DZ0Nx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p97DZ0Nx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5591C4CECD; Sat, 28 Dec 2024 19:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735414095; bh=VSUk2RevzgoLpoKkPtxfiydxyc1+Qk/NEc9zjGax7Xk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p97DZ0NxPjGkbuXixh57qRqbuQKgJZPDSIGYm/BKzAvRZnVo5XPlJeD7IlSZPK28N MWU+h4Bf8EnSUeV7GmbAfRmCkUYFI4NdO0FRojFFpZZCbPXEvqeZDcuo+M6V0PyThr rgQYj2aKj9bq49LOrMhNDyn7N6SULRxmi42Akcwb4h3BmP0I9TNb0JBo/az9tNlWDl DuCYfNJWALOAaSvw6Nl9/62rb9uSR01ECmkTKNp3py1oP937PV7gmWulCyF59Qnp7C ZrDPKZtHQvPinLaUX2u6zAEfj0PlMpCk3yGq5vodrFz3yE7NeQAX2eiv2HkTwhexae pEMyZr2EGOM1g== Message-ID: <6b2b5cf5-6988-4860-bda5-742dffce0db2@kernel.org> Date: Sat, 28 Dec 2024 13:28:11 -0600 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path Content-Language: en-US To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Jonathan Corbet , Andrew Lunn , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , Kaiyuan Zhang , Pavel Begunkov , Willem de Bruijn , Samiullah Khawaja , Stanislav Fomichev , Joe Damato , dw@davidwei.uk References: <20241221004236.2629280-1-almasrymina@google.com> <20241221004236.2629280-6-almasrymina@google.com> From: David Ahern In-Reply-To: <20241221004236.2629280-6-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/20/24 5:42 PM, Mina Almasry wrote: > diff --git a/include/uapi/linux/uio.h b/include/uapi/linux/uio.h > index 649739e0c404..41490cde95ad 100644 > --- a/include/uapi/linux/uio.h > +++ b/include/uapi/linux/uio.h > @@ -38,6 +38,11 @@ struct dmabuf_token { > __u32 token_count; > }; > > +struct dmabuf_tx_cmsg { > + __u32 dmabuf_id; I believe you need to make sure the u64 is properly aligned: __u32 unused; // and verify it is set to 0 > + __u64 dmabuf_offset; > +}; > + > /* > * UIO_MAXIOV shall be at least 16 1003.1g (5.4.1.1) > */