public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Shah, Amit" <Amit.Shah@amd.com>
To: "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
	"bp@alien8.de" <bp@alien8.de>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
	"pawan.kumar.gupta@linux.intel.com"
	<pawan.kumar.gupta@linux.intel.com>,
	"kai.huang@intel.com" <kai.huang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"seanjc@google.com" <seanjc@google.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"Moger, Babu" <Babu.Moger@amd.com>,
	"Das1, Sandipan" <Sandipan.Das@amd.com>,
	"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"Kaplan, David" <David.Kaplan@amd.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 1/2] x86/bugs: Don't fill RSB on VMEXIT with eIBRS+retpoline
Date: Wed, 2 Apr 2025 09:19:19 +0000	[thread overview]
Message-ID: <6bfb74e5f05ab8d4cecda1c09a235ccc59c84be6.camel@amd.com> (raw)
In-Reply-To: <20241205231207.ywcruocjqtyjsvxx@jpoimboe>

On Thu, 2024-12-05 at 15:12 -0800, Josh Poimboeuf wrote:
> On Tue, Dec 03, 2024 at 12:20:15PM +0100, Borislav Petkov wrote:
> > On Mon, Dec 02, 2024 at 03:35:21PM -0800, Pawan Gupta wrote:
> > > It is in this doc:
> > > 
> > >  
> > > https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/technical-documentation/indirect-branch-restricted-speculation.html
> > > 
> > 
> > I hope those URLs remain more stable than past experience shows.
> > 
> > >   "Processors with enhanced IBRS still support the usage model
> > > where IBRS is
> > >   set only in the OS/VMM for OSes that enable SMEP. To do this,
> > > such
> > >   processors will ensure that guest behavior cannot control the
> > > RSB after a
> > >   VM exit once IBRS is set, even if IBRS was not set at the time
> > > of the VM
> > >   exit."
> > 
> > ACK, thanks.
> > 
> > Now, can we pls add those excerpts to Documentation/ and point to
> > them from
> > the code so that it is crystal clear why it is ok?
> 
> Ok, I'll try to write up a document.  I'm thinking it should go in
> its
> own return-based-attacks.rst file rather than spectre.rst, which is
> more
> of an outdated historical document at this point.  And we want this
> document to actually be read (and kept up to date) by developers
> instead
> of mostly ignored like the others.
> 

Hey Josh,

Do you plan to submit a v3 with the changes?

Thanks,

		Amit

  parent reply	other threads:[~2025-04-02  9:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21 20:07 [PATCH v2 0/2] x86/bugs: RSB tweaks Josh Poimboeuf
2024-11-21 20:07 ` [PATCH v2 1/2] x86/bugs: Don't fill RSB on VMEXIT with eIBRS+retpoline Josh Poimboeuf
2024-11-30 15:31   ` Borislav Petkov
2024-12-02 11:15     ` Shah, Amit
2024-12-02 12:19       ` Borislav Petkov
2024-12-02 23:35     ` Pawan Gupta
2024-12-03 11:20       ` Borislav Petkov
2024-12-05 23:12         ` Josh Poimboeuf
2024-12-21  9:13           ` Borislav Petkov
2025-04-02  9:19           ` Shah, Amit [this message]
2025-04-02 14:16             ` Josh Poimboeuf
2025-04-02 14:19               ` Shah, Amit
2024-12-05 23:13     ` Josh Poimboeuf
2024-11-21 20:07 ` [PATCH v2 2/2] x86/bugs: Don't fill RSB on context switch with eIBRS Josh Poimboeuf
2024-12-03 11:42   ` Borislav Petkov
2024-12-05 23:32   ` Josh Poimboeuf
2024-12-06  0:53     ` Josh Poimboeuf
2024-12-06 23:02       ` Josh Poimboeuf
2024-12-30 14:54         ` Shah, Amit
2025-01-08 11:50         ` Shah, Amit
2024-12-06 10:10     ` Shah, Amit
2024-12-09 20:46       ` jpoimboe
2024-11-28 13:28 ` [RFC PATCH v3 0/2] Add support for the ERAPS feature Amit Shah
2024-11-28 13:28   ` [RFC PATCH v3 1/2] x86: cpu/bugs: add AMD ERAPS support; hardware flushes RSB Amit Shah
2024-12-02 17:26     ` Dave Hansen
2024-12-02 18:09       ` Amit Shah
2024-12-02 18:25         ` Dave Hansen
2024-12-02 18:36           ` Sean Christopherson
2024-11-28 13:28   ` [RFC PATCH v3 2/2] x86: kvm: svm: advertise ERAPS (larger RSB) support to guests Amit Shah
2024-12-02 18:30     ` Sean Christopherson
2025-03-27 11:10       ` Shah, Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bfb74e5f05ab8d4cecda1c09a235ccc59c84be6.camel@amd.com \
    --to=amit.shah@amd.com \
    --cc=Babu.Moger@amd.com \
    --cc=David.Kaplan@amd.com \
    --cc=Sandipan.Das@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox