Re: [PATCH v11 04/13] vfio/pci: Add VFIO_REGION_TYPE_NESTED region type

Auger Eric
2021-02-23T12:59:43Z

Hi Shenming,

On 2/23/21 1:45 PM, Shenming Lu wrote:
>> +static int vfio_pci_dma_fault_init(struct vfio_pci_device *vdev)
>> +{
>> + struct vfio_region_dma_fault *header;
>> + struct iommu_domain *domain;
>> + size_t size;
>> + bool nested;
>> + int ret;
>> +
>> + domain = iommu_get_domain_for_dev(&vdev->pdev->dev);
>> + ret = iommu_domain_get_attr(domain, DOMAIN_ATTR_NESTING, &nested);
>> + if (ret || !nested)
>> + return ret;
>
> Hi Eric,
>
> It seems that the type of nested should be int, the use of bool might trigger
> a panic in arm_smmu_domain_get_attr().

Thank you. That's fixed now.

Best Regards

Eric
>
> Thanks,
> Shenming
>