From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register Date: Wed, 10 May 2017 17:35:53 +0200 Message-ID: <6d515b93-e7e2-fbae-a91c-12b98fe923de@redhat.com> References: <1494411564-76243-1-git-send-email-wanpeng.li@hotmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <1494411564-76243-1-git-send-email-wanpeng.li@hotmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 10/05/2017 12:19, Wanpeng Li wrote: > * with old userspace. > */ > - if (xstate_bv & ~kvm_supported_xcr0()) > + if (xstate_bv & ~kvm_supported_xcr0() || > + mxcsr & ~vcpu->arch.guest_fpu.state.xsave.i387.mxcsr_mask) > return -EINVAL; > load_xsave(vcpu, (u8 *)guest_xsave->region); > } else { > - if (xstate_bv & ~XFEATURE_MASK_FPSSE) > + if (xstate_bv & ~XFEATURE_MASK_FPSSE || > + mxcsr & ~vcpu->arch.guest_fpu.state.fxsave.mxcsr_mask) > return -EINVAL; > memcpy(&vcpu->arch.guest_fpu.state.fxsave, > guest_xsave->region, sizeof(struct fxregs_state)); Hmm, thinking more about it, maybe use mxcsr_feature_mask instead of digging into vcpu->arch.guest_fpu? If you send v2, please remember to Cc stable@vger.kernel.org. Paolo