From: Paolo Bonzini <pbonzini@redhat.com>
To: yunhong jiang <yunhong.jiang@linux.intel.com>
Cc: "David Matlack" <dmatlack@google.com>,
"kvm list" <kvm@vger.kernel.org>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <kernellwp@gmail.com>
Subject: Re: [RFC PATCH V2 4/4] Utilize the vmx preemption timer for tsc deadline timer
Date: Thu, 26 May 2016 09:20:56 +0200 [thread overview]
Message-ID: <6de080a0-fc63-71b8-355d-678e007c89a5@redhat.com> (raw)
In-Reply-To: <20160525155324.16ed5f0c@jnakajim-build>
On 26/05/2016 00:53, yunhong jiang wrote:
> Hmm, I can fix this on my next submission. Or someone can send out a separate
> patch for it.
Alan Jenkins is looking at it in another thread.
>> > You copied the wrong URL, but at least lines 1383-1410 seem okay to
>> > me.
> Yes, I mean 1383~1410. On L1402, "expire = ktime_add_ns(now, ns)", I think the
> "now" is host tsc while "ns" is guest delta tsc, which seems a bug to me. Or I
> miss-understand anything?
now is nanoseconds, coming from struct hrtimer_clock_base.
ns is nanoseconds, computed from (tscdeadline - guest_tsc) * 1000000 /
vcpu->arch.virtual_tsc_khz.
Thanks,
Paolo
next prev parent reply other threads:[~2016-05-26 7:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 22:27 [RFC PATCH V2 0/4] Utilizing VMX preemption for timer virtualization Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 1/4] Add the kvm sched_out hook Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 2/4] Utilize the vmx preemption timer Yunhong Jiang
2016-06-14 13:23 ` Roman Kagan
2016-06-14 13:41 ` Paolo Bonzini
2016-06-14 16:46 ` yunhong jiang
2016-06-14 21:56 ` Paolo Bonzini
2016-06-15 18:03 ` yunhong jiang
2016-06-14 16:46 ` yunhong jiang
2016-05-24 22:27 ` [RFC PATCH V2 3/4] Separate the start_sw_tscdeadline Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 4/4] Utilize the vmx preemption timer for tsc deadline timer Yunhong Jiang
2016-05-24 23:11 ` David Matlack
2016-05-24 23:35 ` yunhong jiang
2016-05-25 11:58 ` Paolo Bonzini
2016-05-25 22:53 ` yunhong jiang
2016-05-26 7:20 ` Paolo Bonzini [this message]
2016-05-25 10:40 ` Paolo Bonzini
2016-05-25 13:38 ` Radim Krčmář
2016-05-25 11:52 ` Paolo Bonzini
2016-05-25 22:44 ` yunhong jiang
2016-05-26 14:05 ` Alan Jenkins
2016-05-26 15:32 ` Paolo Bonzini
2016-06-04 0:24 ` yunhong jiang
2016-06-06 13:49 ` Paolo Bonzini
2016-06-06 18:21 ` yunhong jiang
2016-05-25 13:27 ` Radim Krčmář
2016-05-25 13:51 ` Paolo Bonzini
2016-05-25 14:31 ` Radim Krčmář
2016-05-25 23:13 ` yunhong jiang
2016-06-14 11:34 ` Paolo Bonzini
2016-05-25 13:45 ` Radim Krčmář
2016-05-25 22:57 ` yunhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de080a0-fc63-71b8-355d-678e007c89a5@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yunhong.jiang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).