From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirti Wankhede Subject: Re: [PATCH 5/8] vfio/mdev: Avoid masking error code to EBUSY Date: Tue, 26 Mar 2019 00:48:21 +0530 Message-ID: <6f990e18-296c-cd33-df2b-c5c4bad7a740@nvidia.com> References: <1553296835-37522-1-git-send-email-parav@mellanox.com> <1553296835-37522-6-git-send-email-parav@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Parav Pandit , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alex.williamson@redhat.com" Return-path: In-Reply-To: <1553296835-37522-6-git-send-email-parav@mellanox.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 3/23/2019 4:50 AM, Parav Pandit wrote: > Instead of masking return error to -EBUSY, return actual error > returned by the driver. > > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 3d91f62..ab05464 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -142,7 +142,7 @@ static int mdev_device_remove_ops(struct mdev_device *mdev, bool force_remove) > */ > ret = parent->ops->remove(mdev); > if (ret && !force_remove) > - return -EBUSY; > + return ret; > > sysfs_remove_groups(&mdev->dev.kobj, parent->ops->mdev_attr_groups); > return 0; > Intentionally returned -EBUSY here. If VMM or userspace application is using this mdev device, vendor driver can return error. In that case sysfs interface should see -EBUSY error indicating device is still active. Thanks, Kirti