From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE3B127E06D for ; Fri, 11 Jul 2025 09:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752227124; cv=none; b=eGcQ3fr4nhw25qhzg2mu189bortJjKRflvxbUZBrgnx5YeIY9qVowcrslx4jhVhDvZDzHAKUoOCh/FTxCGyZZHKbJ/Iuy0A9Hh3YqP5ublLgY/5xBl+uxdX+vmUzSiH05oznWZwBObcN62IW5esDPkt/ijdeSnYRPqzHD00HCxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752227124; c=relaxed/simple; bh=G9mm78zXYI6piKO+tCuvJ8phdn2YIo88+qdAXqWDekI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oUZ2rzYsnKuLgmgtO0gTOj2KyzFmO8rynZuba3Aw5dDSMfpYromlJIlS4fsohpv2kSy2DO0pSzy0i/ScYYc17jeP5jYW8CAtiI3ZoPLyFZaX9a7kg1QJH+tFjIAHBQN2n1ztQLskojAE2hX5G/ITdrCjHntNLggAxOyYHg7PVTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Keqr5+Fn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Keqr5+Fn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752227121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QSYtK8W1hoFX+G4/TI9sDJE2SYg5NnfEH2SkGUJResc=; b=Keqr5+Fnwb7K6orxG//0TKcY54vswYkr5JdcVizKgVzkiGakt+kROFjLHYaTDlEO8cmXes 39HpyQALbuiT5sQ397k1EeC30MXT9qGyBJW9r6JbiiA8EFfyAakjKaNA0upzvCkBglRttO u/dlbJl3VioZlQxMPOlyCmuqP0Pfimg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-_jvpW098N7Cia1UydMisOA-1; Fri, 11 Jul 2025 05:45:20 -0400 X-MC-Unique: _jvpW098N7Cia1UydMisOA-1 X-Mimecast-MFC-AGG-ID: _jvpW098N7Cia1UydMisOA_1752227119 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4538f375e86so14857225e9.3 for ; Fri, 11 Jul 2025 02:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752227119; x=1752831919; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QSYtK8W1hoFX+G4/TI9sDJE2SYg5NnfEH2SkGUJResc=; b=jxAgKujoN+S4w7SrM0nGIS4eGPnb+edsfZc+D2kkkm2m8J3g6bSbiw5BlzZt4y2dXn l0YWOM0SGt5PBxXpTVtiOalEnZkpG5Kd5zxM3zSJ2TYdf+qJAtZN/QwJV8TQbGokN2yo HzJkr/FKHSXfqRbf6E5sEHRirs6wcd/p+5EJBwM1LyvQP6d8EAp5y9E4oB4ypo3Bp2b0 1ivMjk/YfZGLjACJDg0o6a16ytHui3n5PxA6FDbVZKFjZUNUAXJuVGHj6vlsgkhb7N9F SdX0uIwccLWFAwwp6orgQS/g0nKroiKSCFwXuNtNgr96hHO1KnG4mj133S4bMCUdIfmw JPlw== X-Forwarded-Encrypted: i=1; AJvYcCVnjvxrkrRuW/OL15YLrFF+hqxwviJz2n3DrlD+QG4s8Eqs8J0aqz+1apMLAuLOrAOJ5jQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbs4Jgksj9f1UNyv9BfF7chXkPa3K3ATFS2ELszANua444EVy/ 07NPhOlWB+tl8g+Sr66BedwMuiu2c1QiUjDExyd1+0KHLVaEuAmm6eRZpwtNBUQNEYKY6UT0Q1Q fgNMTuR/ECAyr+N/dOZofFftIA+MzMeGR0BmXMlE6vfqUXDruSM/J+g== X-Gm-Gg: ASbGncsNVyeTY3X4oP2jSXT9zfyMUPIXMMPQIaW674vLRiuWrLPqhGGmVK0M0ggsHg7 mLQDvkSM0mKHmurydGMthxG89bJh1EWfuSnadH5VlUVAP4USY8ell7DngMy+RC6s6YyHv3npUnh oeJS5Cqnhwc85qpVf8MIQ7PoLTVIkxe2+trPuoixAZFf3kOHs0KvhL+aoheoITbAgumbldz1Mku FQ+cr4240aqPQvURqUMpUtuzR78XGZgfLovrByjMHVRHoGocYuFarNfIGwcVc0KJpZagV3yWN6k ZuOq6y3UkjxIb7FaSnqdX07eN6yYxc5eL3xSwbqZ0XPxngMECfALRghQ30p5YDoI1XTtB+c70gU DX4tm7TZS2/s2XVBltK1tiFv7r2hml45eKmHf7sqN4e91X+SenHxhb4C1rl9BkR99A9g= X-Received: by 2002:a05:600c:46c3:b0:453:8bc7:5cbb with SMTP id 5b1f17b1804b1-454ec281d0amr20339435e9.25.1752227118962; Fri, 11 Jul 2025 02:45:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFnas8XgQ3IWLS2hIV11hHrPJlB9u2ohUWXcGE0uQdIEF9JiXqxZYBzaTwnR729ZNAjccDGg== X-Received: by 2002:a05:600c:46c3:b0:453:8bc7:5cbb with SMTP id 5b1f17b1804b1-454ec281d0amr20338625e9.25.1752227118391; Fri, 11 Jul 2025 02:45:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454d50df0cdsm84339815e9.25.2025.07.11.02.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 02:45:17 -0700 (PDT) Message-ID: <6fc1edd4-8a3c-4cba-8779-461a16b5126e@redhat.com> Date: Fri, 11 Jul 2025 11:45:15 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 14/20] KVM: x86: Enable guest_memfd mmap for default VM type To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250709105946.4009897-1-tabba@google.com> <20250709105946.4009897-15-tabba@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709105946.4009897-15-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.07.25 12:59, Fuad Tabba wrote: > Enable host userspace mmap support for guest_memfd-backed memory when > running KVM with the KVM_X86_DEFAULT_VM type: > > * Define kvm_arch_supports_gmem_mmap() for KVM_X86_DEFAULT_VM: Introduce > the architecture-specific kvm_arch_supports_gmem_mmap() macro, > specifically enabling mmap support for KVM_X86_DEFAULT_VM instances. > This macro, gated by CONFIG_KVM_GMEM_SUPPORTS_MMAP, ensures that only > the default VM type can leverage guest_memfd mmap functionality on > x86. This explicit enablement prevents CoCo VMs, which use guest_memfd > primarily for private memory and rely on hardware-enforced privacy, > from accidentally exposing guest memory via host userspace mappings. > > * Select CONFIG_KVM_GMEM_SUPPORTS_MMAP in KVM_X86: Enable the > CONFIG_KVM_GMEM_SUPPORTS_MMAP Kconfig option when KVM_X86 is selected. > This ensures that the necessary code for guest_memfd mmap support > (introduced earlier) is compiled into the kernel for x86. This Kconfig > option acts as a system-wide gate for the guest_memfd mmap capability. > It implicitly enables CONFIG_KVM_GMEM, making guest_memfd available, > and then layers the mmap capability on top specifically for the > default VM. > > These changes make guest_memfd a more versatile memory backing for > standard KVM guests, allowing VMMs to use a unified guest_memfd model > for both private (CoCo) and non-private (default) VMs. This is a > prerequisite for use cases such as running Firecracker guests entirely > backed by guest_memfd and implementing direct map removal for non-CoCo > VMs. > > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > Signed-off-by: Fuad Tabba > --- > arch/x86/include/asm/kvm_host.h | 9 +++++++++ > arch/x86/kvm/Kconfig | 1 + > arch/x86/kvm/x86.c | 3 ++- > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 4c764faa12f3..4c89feaa1910 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -2273,9 +2273,18 @@ void kvm_configure_mmu(bool enable_tdp, int tdp_forced_root_level, > #ifdef CONFIG_KVM_GMEM > #define kvm_arch_has_private_mem(kvm) ((kvm)->arch.has_private_mem) > #define kvm_arch_supports_gmem(kvm) ((kvm)->arch.supports_gmem) > + > +/* > + * CoCo VMs with hardware support that use guest_memfd only for backing private > + * memory, e.g., TDX, cannot use guest_memfd with userspace mapping enabled. > + */ > +#define kvm_arch_supports_gmem_mmap(kvm) \ > + (IS_ENABLED(CONFIG_KVM_GMEM_SUPPORTS_MMAP) && \ > + (kvm)->arch.vm_type == KVM_X86_DEFAULT_VM) > #else > #define kvm_arch_has_private_mem(kvm) false > #define kvm_arch_supports_gmem(kvm) false > +#define kvm_arch_supports_gmem_mmap(kvm) false > #endif > > #define kvm_arch_has_readonly_mem(kvm) (!(kvm)->arch.has_protected_state) > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > index df1fdbb4024b..239637b663dc 100644 > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -47,6 +47,7 @@ config KVM_X86 > select KVM_GENERIC_HARDWARE_ENABLING > select KVM_GENERIC_PRE_FAULT_MEMORY > select KVM_GENERIC_GMEM_POPULATE if KVM_SW_PROTECTED_VM > + select KVM_GMEM_SUPPORTS_MMAP > select KVM_WERROR if WERROR Given the error, likely we want to limit to 64BIT. select KVM_GMEM_SUPPORTS_MMAP if X86_64 -- Cheers, David / dhildenb