From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xu, Yilun" <yilun.xu@intel.com>,
"artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Gao, Chao" <chao.gao@intel.com>,
"Fang, Peter" <peter.fang@intel.com>,
"Maloor, Kishen" <kishen.maloor@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 5/6] x86/virt/tdx: Make TDX module initialize the extensions
Date: Mon, 24 Aug 2026 17:43:28 +0000 [thread overview]
Message-ID: <6ffb491ea0252acd60982330be1e7ca1e8dcb23a.camel@intel.com> (raw)
In-Reply-To: <aox8DgpnSnhZRfCv@yilunxu-OptiPlex-7050>
On Tue, 2026-08-25 at 01:14 +0800, Xu Yilun wrote:
> > What exactly does TDH.EXT.INIT actually do,
>
> The SPEC just said it "initializes TDX module extension". My
> understanding is that it builds the SEAMCALL execution context by
> setting up its internal data on the memory added by TDH.EXT.MEM.ADD
>
> > and why can't whatever that is
> > happen during TDH.EXT.MEM.ADD?
>
> Do you mean why can't the extensions initialization happen on last
> TDH.EXT.MEM.ADD?
Not specifically. Just wondering what it is doing. Like is it the big operation
to prep the memory, and ADD just hands pages which sit on a list waiting the
real work? Or more like a "we think we are good to go" notification from the
VMM?
> I can think of some case that TDH.EXT.MEM.ADD is not
> needed but the extensions initialization is needed. For example: after
> an compatible TDX module update.
>
> I may ask the TDX module team to get a better understanding.
That this is also called during an update just raises further questions to me.
If is doing initing of the memory, then what happens during an update? I'd
expect memory would need to be persisted across an update, not initialized. Or
it is doing something different when called after a TDH.SYS.UPDATE? Does it
consume the handoff data?
next prev parent reply other threads:[~2026-08-24 17:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 3:29 [PATCH 0/6] Enable TDX module extensions Xu Yilun
2026-08-21 3:29 ` [PATCH 1/6] x86/virt/tdx: Wrap TDH.SYS.CONFIG/UPDATE operations in helpers Xu Yilun
2026-08-21 20:53 ` Edgecombe, Rick P
2026-08-24 4:52 ` Xu Yilun
2026-08-21 3:29 ` [PATCH 2/6] x86/virt/tdx: Configure add-on features on TDX module init and update Xu Yilun
2026-08-21 14:38 ` Dave Hansen
2026-08-21 21:18 ` Edgecombe, Rick P
2026-08-24 6:37 ` Xu Yilun
2026-08-24 15:15 ` Dave Hansen
2026-08-24 18:34 ` Xu Yilun
2026-08-21 22:01 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 3/6] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-08-21 15:22 ` Kiryl Shutsemau
2026-08-21 22:22 ` Edgecombe, Rick P
2026-08-24 12:16 ` Kiryl Shutsemau
2026-08-21 3:29 ` [PATCH 4/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-08-21 15:44 ` Kiryl Shutsemau
2026-08-24 9:18 ` Xu Yilun
2026-08-24 12:22 ` Kiryl Shutsemau
2026-08-21 3:29 ` [PATCH 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-08-21 23:55 ` Edgecombe, Rick P
2026-08-24 17:14 ` Xu Yilun
2026-08-24 17:43 ` Edgecombe, Rick P [this message]
2026-08-24 17:58 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
2026-08-22 0:01 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ffb491ea0252acd60982330be1e7ca1e8dcb23a.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox