From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9519128378 for ; Mon, 3 Jun 2024 09:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407021; cv=none; b=t2pb9/TYp2LDzNOXrwkg+tz9sh6mENyaZvXizXHyvkjtLAMrMWYPRo/CbpYKojOXOeTvlLIBGuaUstthEoUbRtqUmJUTglRNERlPUoK1WHNgxrI6CMexw2rRZYc9JFO+JX4sayNCS1ni+n6SG0hQOFohYHO0ScRdbKGPZ3maQUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407021; c=relaxed/simple; bh=GVlglyDF8DZwBbSeuEg6JU2cbcHWbIgTItC8sFcfgBY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RDLNNAOfU8akfqzxNDn5FIzTW2EDBltiMN+i7cyl8TIjBn1zlE1dRhmVl0xtfo0RZTSYhvDjBeR1j3obRADiklqmD0R5miz8KhRxcRMY4iGFJnanhEevim4gGlgOFKgbWVO4RZz+H9FrvtD9hN9yE3P6TGAht10jbladk03N+0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BeOR4q2p; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BeOR4q2p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717407018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ATKzEjTtVPhwoSjjxK06J60WfW4dF9UMbHQlAPwliZ4=; b=BeOR4q2p2u2u3YZmkHnQ/3KpLBGJhT0CPICg13nnYnFnKoQSsXP5HDog14pdZrF+v7B8FJ FD3ZHjSzGDoazGpn0RrniLFuKKhDZhR9Sil6UCTT1Rw5hjlftLnxKIeIu2hS2w0ytTwuE3 GEjIEOEuI4WJUn7TjaolGPfh+lOHyjU= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-xsWYJ0o3P-6JA1x385wrNw-1; Mon, 03 Jun 2024 05:30:17 -0400 X-MC-Unique: xsWYJ0o3P-6JA1x385wrNw-1 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-80ac355e3baso1008034241.0 for ; Mon, 03 Jun 2024 02:30:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717407017; x=1718011817; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ATKzEjTtVPhwoSjjxK06J60WfW4dF9UMbHQlAPwliZ4=; b=YYvyL1zzegnwh5XWISn8f6s8TtAZIh6D0FYx34DPshcSmHi4lvTmSCaPoa4joiSzJd Bhg90D+jPRy+0Fe7MT2tdTHKyyVlhVL7Y+8asRDXEg38qa2Cgar1nhT94a3Nbu49i55T TqU8SREXRi3Cftr1G3DIg6Duc0cA5dzF3v9KbA9ptYq7YQ4Nu5RM/df7XtH5wvkW22Mb 7U77ctQqhixEMh16MW2Uqrz/5gJpusrJOh/wJNmfhX8UE8Ylj646B3amxfwvrlEGi5Yv M5YeiYAX3D+bI9tgkO7MacwzSMYgu1mg+9DuyA7RuKav6RJGJ2mK/gywid7RlzDKpSAp oj2w== X-Forwarded-Encrypted: i=1; AJvYcCWUC7gj/3Q6uDplDlt3rqjyYh8xY7bwx1HtIsBwqZzT6yQCt2syBmcSdkYFdCYS2fgjYwMYl8D5m4hbiALo0gZaTa0x X-Gm-Message-State: AOJu0YzAjssTxTSHZ6/auO7JeX1mKGF793aVRv2YXP+XcinTsfRotN5c 66CO9HTDcPv3WS5g5FPOTi1E9qHVnfn8R1EsX5P/mpOIVuHlDZY2a/75LvKPAWlFmrmTwUbwP3y ybIlg0E48EjUeMPhQ8FoQ0oNArQgcPQ93ciD8UTqwg+OmWKfXEg== X-Received: by 2002:a05:6102:4611:b0:48b:bee2:51b7 with SMTP id ada2fe7eead31-48bc21fdcf2mr8405401137.20.1717407016817; Mon, 03 Jun 2024 02:30:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlN4I59TIHRaEkyAfCcRV5h9lx+hRj1kj+g78z3rnLpQBN/u6U+5EiPCZTHbCyPkEEfN3FiA== X-Received: by 2002:a05:6102:4611:b0:48b:bee2:51b7 with SMTP id ada2fe7eead31-48bc21fdcf2mr8405386137.20.1717407016434; Mon, 03 Jun 2024 02:30:16 -0700 (PDT) Received: from [192.168.0.4] (ip-109-43-176-229.web.vodafone.de. [109.43.176.229]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-80adf321cb1sm867963241.39.2024.06.03.02.30.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 02:30:16 -0700 (PDT) Message-ID: <7059d458-048a-40a5-b21e-4e15568d1f54@redhat.com> Date: Mon, 3 Jun 2024 11:30:08 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [kvm-unit-tests PATCH v9 14/31] powerpc: Remove broken SMP exception stack setup To: Nicholas Piggin Cc: Laurent Vivier , Andrew Jones , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org References: <20240504122841.1177683-1-npiggin@gmail.com> <20240504122841.1177683-15-npiggin@gmail.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240504122841.1177683-15-npiggin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/05/2024 14.28, Nicholas Piggin wrote: > The exception stack setup does not work correctly for SMP, because > it is the boot processor that calls cpu_set() which sets SPRG2 to > the exception stack, not the target CPU itself. So secondaries > never got their SPRG2 set to a valid exception stack. So secondary CPUs currently must not run into any exceptions? > Remove the SMP code and just set an exception stack for the boot > processor. Make the stack 64kB while we're here, to match the > size of the regular stack. > > Signed-off-by: Nicholas Piggin > --- > lib/powerpc/setup.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Thomas Huth