From: Janosch Frank <frankja@linux.ibm.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>,
linux-s390@vger.kernel.org, Thomas Huth <thuth@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>
Cc: kvm@vger.kernel.org, Nico Boehr <nrb@linux.ibm.com>,
Steffen Eiden <seiden@linux.ibm.com>
Subject: Re: [kvm-unit-tests PATCH v1 1/3] s390x/Makefile: snippets: Add separate target for the ELF snippets
Date: Fri, 26 Jul 2024 12:01:34 +0200 [thread overview]
Message-ID: <726edbf8-752c-46ed-afb4-587b714e4052@linux.ibm.com> (raw)
In-Reply-To: <20240604115932.86596-2-mhartmay@linux.ibm.com>
On 6/4/24 1:59 PM, Marc Hartmayer wrote:
> It's unusual to create multiple files in one target rule, and it's even more
> unusual to create an ELF file with a `.gbin` file extension first, and then
> overwrite it in the next step. It might even lead to errors as the input file
> path is also used as the output file path - but this depends on the objcopy
> implementation. Therefore, create an extra target for the ELF files and list it
> as a prerequisite for the *.gbin targets.
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2024-07-26 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 11:59 [kvm-unit-tests PATCH v1 0/3] s390x: small Makefile improvements Marc Hartmayer
2024-06-04 11:59 ` [kvm-unit-tests PATCH v1 1/3] s390x/Makefile: snippets: Add separate target for the ELF snippets Marc Hartmayer
2024-06-05 1:21 ` Nicholas Piggin
2024-06-05 7:32 ` Marc Hartmayer
2024-07-26 10:01 ` Janosch Frank [this message]
2024-07-29 7:00 ` Janosch Frank
2024-07-29 7:41 ` Marc Hartmayer
2024-06-04 11:59 ` [kvm-unit-tests PATCH v1 2/3] s390x/Makefile: snippets: Avoid creation of .eh_frame and .eh_frame_hdr sections Marc Hartmayer
2024-06-04 11:59 ` [kvm-unit-tests PATCH v1 3/3] Revert "s390x: Specify program headers with flags to avoid linker warnings" Marc Hartmayer
2024-06-04 12:04 ` Marc Hartmayer
2024-06-05 1:30 ` [kvm-unit-tests PATCH v1 0/3] s390x: small Makefile improvements Nicholas Piggin
2024-06-05 8:03 ` Marc Hartmayer
2024-07-26 8:31 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=726edbf8-752c-46ed-afb4-587b714e4052@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox