From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E054C433FE for ; Tue, 15 Feb 2022 09:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235748AbiBOJTt (ORCPT ); Tue, 15 Feb 2022 04:19:49 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231371AbiBOJTs (ORCPT ); Tue, 15 Feb 2022 04:19:48 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 315752CCA7; Tue, 15 Feb 2022 01:19:39 -0800 (PST) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21F8IX4m022469; Tue, 15 Feb 2022 09:19:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=uC5XYw6ejz93NnnrjYQXR31cZYiOKzP4B+EfZHcbpJs=; b=bTSoXD4wlj2+Py+FyKdSqQoiRV/Kt/ba3b23g1qF+Kyb2DlPuA77m2hgpUk+ADVf4uKp fbidkRSANZTj2Kpu4+q/1Gwuy3NWpEQlztXJpf8zhy9F3jIRPUAsKflu8lAmI3I1PgHU DE/6n0S0VOhj3wzReHy3ozpIltFrLK/4fTWzA2bKiPAWZNacVTG2HWS5+SRYGho/sQv9 qF9kOSKmt7olEwO+8KrdDekkfSXqg0FPJbzJQzvsP7rUSeItJo4m9vclF8Hz1o4Ot8BD udD0u7egbVdFfOmbyXW8BJPBcZ+ZQDkXv6SBQXuiXlH2znTK7K5w5ST/Dit11SipBaJr KA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e85y44q21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 09:19:38 +0000 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21F8WXYe020994; Tue, 15 Feb 2022 09:19:37 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e85y44q1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 09:19:37 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21F9IHsq010437; Tue, 15 Feb 2022 09:19:36 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma04ams.nl.ibm.com with ESMTP id 3e64h9vwh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Feb 2022 09:19:36 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21F9JWwE46924126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 09:19:32 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D2428A405F; Tue, 15 Feb 2022 09:19:32 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D237A4054; Tue, 15 Feb 2022 09:19:32 +0000 (GMT) Received: from [9.171.31.140] (unknown [9.171.31.140]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 15 Feb 2022 09:19:32 +0000 (GMT) Message-ID: <72d2bb5a-c0aa-6136-0900-58a0474334d9@linux.ibm.com> Date: Tue, 15 Feb 2022 10:21:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [kvm-unit-tests PATCH v4 3/4] s390x: topology: Check the Perform Topology Function Content-Language: en-US From: Pierre Morel To: Nico Boehr , linux-s390@vger.kernel.org Cc: frankja@linux.ibm.com, thuth@redhat.com, kvm@vger.kernel.org, cohuck@redhat.com, imbrenda@linux.ibm.com, david@redhat.com References: <20220208132709.48291-1-pmorel@linux.ibm.com> <20220208132709.48291-4-pmorel@linux.ibm.com> <8dd704d23f8a14907ed2a7f28ec3ac52685ab96c.camel@linux.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZpGNKDpeLSco7mZuGn266mwc2gEzM2EM X-Proofpoint-GUID: GvsfwB1ZsLjqMF3bKhi4WxdYNM3BBYEl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-15_03,2022-02-14_04,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=999 impostorscore=0 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202150052 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2/15/22 09:50, Pierre Morel wrote: > > > On 2/9/22 12:37, Nico Boehr wrote: >> On Tue, 2022-02-08 at 14:27 +0100, Pierre Morel wrote: >>> We check the PTF instruction. >> >> You could test some very basic things as well: >> >> - you get a privileged pgm int in problem state, >> - reserved bits in first operand cause specification pgm int, >> - reserved FC values result in a specification pgm int, >> - second operand is ignored. > > Which second operand? Sorry got it > >> >>> >>> - We do not expect to support vertical polarization. >>> >>> - We do not expect the Modified Topology Change Report to be >> [...] >> >> Forgive me if I'm missing something, but why _Modified_ Topology Change >> Report? >> >>> diff --git a/s390x/topology.c b/s390x/topology.c >>> new file mode 100644 >>> index 00000000..a1f9ce51 >>> --- /dev/null >>> +++ b/s390x/topology.c >> >> [...] >> >>> +static int ptf(unsigned long fc, unsigned long *rc) >>> +{ >>> +       int cc; >>> + >>> +       asm volatile( >>> +               "       .insn   rre,0xb9a20000,%1,0\n" >>> +               "       ipm     %0\n" >>> +               "       srl     %0,28\n" >>> +               : "=d" (cc), "+d" (fc) >>> +               : "d" (fc) >> >> Why list fc here again? >> >> > -- Pierre Morel IBM Lab Boeblingen