Re: [PATCH 11 of 17] Move msrs functions to libkvm-x86.c

Hollis Blanchard
2007-11-08T18:59:52Z

On Thu, 2007-11-08 at 07:54 +0200, Avi Kivity wrote:
> Carlo Marcelo Arenas Belon wrote:
> > On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote:
> >
> >> Move msrs functions to libkvm-x86.c
> >>
> >> This patch moves functions:
> >> kvm_msr_list
> >> move kvm_get_msrs
> >> move kvm_set_msrs
> >>
> >
> > the problem is that with this the definitions were moved as well from libkvm.h
> > to kvm-x86.h which is private and not meant to be exported outside of libkvm
> > but those 3 functions are used by qemu-kvm.c as shown by :
> >
> >
>
> They need to be moved back to libkvm.h with a #ifdef. And to the #ifdef
> purists I say: deorbit.

Re-entry is looking rough; things are much better up here. ;)

Anyways, you don't need to ifdef a prototype; just don't call it.

Also, naming them kvm_x86_get_msrs() and kvm_x86_set_msrs() would be a
much better warning sign for callers.

--
Hollis Blanchard
IBM Linux Technology Center