Re: [PATCH 11 of 17] Move msrs functions to libkvm-x86.c

Avi Kivity
2007-11-08T05:54:54Z

Carlo Marcelo Arenas Belon wrote:
> On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote:
>
>> Move msrs functions to libkvm-x86.c
>>
>> This patch moves functions:
>> kvm_msr_list
>> move kvm_get_msrs
>> move kvm_set_msrs
>>
>
> the problem is that with this the definitions were moved as well from libkvm.h
> to kvm-x86.h which is private and not meant to be exported outside of libkvm
> but those 3 functions are used by qemu-kvm.c as shown by :
>
>

They need to be moved back to libkvm.h with a #ifdef. And to the #ifdef
purists I say: deorbit.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.