From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops
 structure of mdev
Date: Thu, 17 Nov 2016 10:35:58 +0530
Message-ID: <7465681f-f076-20ab-18aa-444b49cbfe11@nvidia.com>
References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com>
 <1479329194-10247-13-git-send-email-kwankhede@nvidia.com>
 <20161117021533.GD6620@bjsdjshi@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
To: <alex.williamson@redhat.com>, <pbonzini@redhat.com>,
        <kraxel@redhat.com>, <cjia@nvidia.com>, <qemu-devel@nongnu.org>,
        <kvm@vger.kernel.org>, <kevin.tian@intel.com>,
        <jike.song@intel.com>, <bjsdjshi@linux.vnet.ibm.com>,
        <linux-kernel@vger.kernel.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20161117021533.GD6620@bjsdjshi@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 11/17/2016 7:45 AM, Dong Jia Shi wrote:
> * Kirti Wankhede <kwankhede@nvidia.com> [2016-11-17 02:16:24 +0530]:
> 
> Hi Kirti,
> 
>> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> [...]
> 
>> @@ -51,6 +78,11 @@ static void vfio_mdev_release(void *device_data)
>>  	if (likely(parent->ops->release))
>>  		parent->ops->release(mdev);
>>
>> +	if (likely(parent->ops->notifier)) {
>> +		if (vfio_unregister_notifier(&mdev->dev, &mdev->nb))
>> +			pr_err("Failed to unregister notifier for mdev\n");
> For the -ENOTTY case, we should not fail here either.
> 

Removing the error print and ignoring return from this unregister call.
Updating this patch on this thread.

>> +	}
>> +
>>  	module_put(THIS_MODULE);
>>  }
>>
> [...]
>