From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Link Mauve <linkmauve@linkmauve.fr>
Cc: linuxppc-dev@lists.ozlabs.org,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Juergen Gross" <jgross@suse.com>,
"Ajay Kaher" <ajay.kaher@broadcom.com>,
"Alexey Makhalov" <alexey.makhalov@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Geoff Levand" <geoff@infradead.org>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
"Anatolij Gustschin" <agust@denx.de>,
"Breno Leitão" <leitao@debian.org>,
"Nayna Jain" <nayna@linux.ibm.com>,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Thorsten Blum" <thorsten.blum@linux.dev>,
"Thomas Huth" <thuth@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"David Hildenbrand" <david@kernel.org>,
"Alistair Popple" <apopple@nvidia.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Donet Tom" <donettom@linux.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Will Deacon" <will@kernel.org>,
"Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
"Paul Moore" <paul@paul-moore.com>,
"Nam Cao" <namcao@linutronix.de>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Sourabh Jain" <sourabhjain@linux.ibm.com>,
"Hari Bathini" <hbathini@linux.ibm.com>,
"Srikar Dronamraju" <srikar@linux.ibm.com>,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Jiri Bohac" <jbohac@suse.cz>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Kees Cook" <kees@kernel.org>,
"Stephen Rothwell" <sfr@cab.auug.org.au>,
"Xichao Zhao" <zhao.xichao@vivo.com>,
"Gautam Menghani" <gautam@linux.ibm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Guangshuo Li" <lgs201920130244@gmail.com>,
"Li Chen" <chenl311@chinatelecom.cn>,
"Aboorva Devarajan" <aboorvad@linux.ibm.com>,
"Petr Mladek" <pmladek@suse.com>,
"Feng Tang" <feng.tang@linux.alibaba.com>,
"Nysal Jan K.A." <nysal@linux.ibm.com>,
"Aditya Gupta" <adityag@linux.ibm.com>,
"Sayali Patil" <sayalip@linux.ibm.com>,
"Rohan McLure" <rmclure@linux.ibm.com>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Yeoreum Yun" <yeoreum.yun@arm.com>,
"Kevin Brodsky" <kevin.brodsky@arm.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Andrew Donnellan" <andrew+kernel@donnellan.id.au>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Athira Rajeev" <atrajeev@linux.ibm.com>,
"Kajol Jain" <kjain@linux.ibm.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Chen Ni" <nichen@iscas.ac.cn>,
"Haren Myneni" <haren@linux.ibm.com>,
"Jonathan Greental" <yonatan02greental@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Yury Norov (NVIDIA)" <yury.norov@gmail.com>,
"Gaurav Batra" <gbatra@linux.ibm.com>,
"Nilay Shroff" <nilay@linux.ibm.com>,
"Vivian Wang" <wangruikang@iscas.ac.cn>,
"Adrian Barnaś" <abarnas@google.com>,
"Rafael J. Wysocki (Intel)" <rafael@kernel.org>,
"Thierry Reding" <treding@nvidia.com>,
"Yury Norov" <ynorov@nvidia.com>,
"Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>,
"Ruben Wauters" <rubenru09@aol.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-crypto@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux.dev, x86@kernel.org
Subject: Re: [PATCH 2/2] powerpc: Run typos -w
Date: Tue, 21 Apr 2026 14:42:47 +0200 [thread overview]
Message-ID: <74c3d4df-4f0c-44b2-9ade-a4b4422d3daf@kernel.org> (raw)
In-Reply-To: <2026042113-shaded-favored-c342@gregkh>
On 21/04/2026 14:36, Greg Kroah-Hartman wrote:
> On Tue, Apr 21, 2026 at 02:14:14PM +0200, Link Mauve wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8308_p1m.dts b/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> index 41f917f97dab..48a98449ecbb 100644
>> --- a/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> +++ b/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> @@ -90,14 +90,14 @@ can@1,0 {
>> compatible = "nxp,sja1000";
>> reg = <0x1 0x0 0x80>;
>> interrupts = <18 0x8>;
>> - interrups-parent = <&ipic>;
>> + interrupts-parent = <&ipic>;
>> };
>>
>> cpld@2,0 {
>> compatible = "denx,mpc8308_p1m-cpld";
>> reg = <0x2 0x0 0x8>;
>> interrupts = <48 0x8>;
>> - interrups-parent = <&ipic>;
>> + interrupts-parent = <&ipic>;
>> };
>> };
>>
>
> Isn't this going to break a working system? If not, then was this dts
> file ever correct in the first place?
It looks DTS was not correct in the first place, but wrong property
probably did not matter, because parent node has it right. Still this is
beyond trivial language fix and should be a separate.
OTOH, interrupts-parent is clearly the wrong property. There is no such
thing.
Quoting commit msg:
"I have manually reviewed every single"
Clearly not true.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-21 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 12:14 [PATCH 0/2] powerpc: Fix a whole bunch of spelling mistakes Link Mauve
2026-04-21 12:14 ` [PATCH 1/2] powerpc: Add a typos.toml file Link Mauve
2026-04-21 12:26 ` Krzysztof Kozlowski
2026-04-21 12:14 ` [PATCH 2/2] powerpc: Run typos -w Link Mauve
2026-04-21 12:36 ` Greg Kroah-Hartman
2026-04-21 12:42 ` Krzysztof Kozlowski [this message]
2026-04-21 17:04 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c3d4df-4f0c-44b2-9ade-a4b4422d3daf@kernel.org \
--to=krzk@kernel.org \
--cc=Jason@zx2c4.com \
--cc=abarnas@google.com \
--cc=aboorvad@linux.ibm.com \
--cc=adityag@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=agust@denx.de \
--cc=ajay.kaher@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.makhalov@broadcom.com \
--cc=andrew+kernel@donnellan.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apopple@nvidia.com \
--cc=ardb@kernel.org \
--cc=atrajeev@linux.ibm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn@rivosinc.com \
--cc=chenl311@chinatelecom.cn \
--cc=chleroy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=donettom@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=feng.tang@linux.alibaba.com \
--cc=gautam@linux.ibm.com \
--cc=gbatra@linux.ibm.com \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=haren@linux.ibm.com \
--cc=hbathini@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jbohac@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=krzk+dt@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leitao@debian.org \
--cc=lgs201920130244@gmail.com \
--cc=linkmauve@linkmauve.fr \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ljs@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=mkchauras@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=namcao@linutronix.de \
--cc=nayna@linux.ibm.com \
--cc=nichen@iscas.ac.cn \
--cc=nilay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nysal@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=paul@paul-moore.com \
--cc=peterz@infradead.org \
--cc=pfsmorigo@gmail.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=rmclure@linux.ibm.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=rubenru09@aol.com \
--cc=sayalip@linux.ibm.com \
--cc=sfr@cab.auug.org.au \
--cc=sourabhjain@linux.ibm.com \
--cc=srikar@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=thorsten.blum@linux.dev \
--cc=thuth@redhat.com \
--cc=treding@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=vishal.moola@gmail.com \
--cc=wangruikang@iscas.ac.cn \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=ynorov@nvidia.com \
--cc=yonatan02greental@gmail.com \
--cc=yury.norov@gmail.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox