Re: [kvm-unit-tests PATCH v4 4/6] s390x: css: implementing Set CHannel Monitor

[Pierre Morel <pmorel@linux.ibm.com>]

On 3/1/21 4:32 PM, Janosch Frank wrote:
> On 3/1/21 12:47 PM, Pierre Morel wrote:
>> We implement the call of the Set CHannel Monitor instruction,
>> starting the monitoring of the all Channel Sub System, and
>> initializing channel subsystem monitoring.
>>
>> Initial tests report the presence of the extended measurement block
>> feature, and verify the error reporting of the hypervisor for SCHM.
> 
> Acked-by: Janosch Frank <frankja@linux.ibm.com>
> 
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>>   lib/s390x/css.h | 12 ++++++++++++
>>   s390x/css.c     | 35 +++++++++++++++++++++++++++++++++++
>>   2 files changed, 47 insertions(+)
>>
>> diff --git a/lib/s390x/css.h b/lib/s390x/css.h
>> index 1cb3de2..b8ac363 100644
>> --- a/lib/s390x/css.h
>> +++ b/lib/s390x/css.h
>> @@ -310,6 +310,7 @@ struct chsc_scsc {
>>   	uint32_t res_04[2];
>>   	struct chsc_header res;
>>   	uint32_t res_fmt;
>> +#define CSSC_EXTENDED_MEASUREMENT_BLOCK 48
>>   	uint64_t general_char[255];
>>   	uint64_t chsc_char[254];
>>   };
>> @@ -360,6 +361,17 @@ bool chsc(void *p, uint16_t code, uint16_t len);
>>   #define css_general_feature(bit) test_bit_inv(bit, chsc_scsc->general_char)
>>   #define css_chsc_feature(bit) test_bit_inv(bit, chsc_scsc->chsc_char)
> 
> css_test_general_feature(bit)
> css_test_chsc_feature(bit)
> 
> ?


Yes,

Thanks,
Pierre
-- 
Pierre Morel
IBM Lab Boeblingen