From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: Aaron Lewis <aaronlewis@google.com>,
Babu Moger <Babu.Moger@amd.com>,
Yang Weijiang <weijiang.yang@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
kvm list <kvm@vger.kernel.org>
Subject: Re: [Patch 6/6] kvm: tests: Add test to verify MSR_IA32_XSS
Date: Thu, 10 Oct 2019 18:01:19 +0200 [thread overview]
Message-ID: <79b9c6f5-9a9d-2ea1-ee84-19d2f5b83089@redhat.com> (raw)
In-Reply-To: <CALMp9eSqy2k2xJo+j2eFf5LNTGctywSt9bFq33iX4nR1gErFcQ@mail.gmail.com>
On 10/10/19 01:44, Jim Mattson wrote:
>>> +uint32_t kvm_get_cpuid_max_basic(void)
>>> +{
>>> + return kvm_get_supported_cpuid_entry(0)->eax;
>>> +}
>>> +
>>> +uint32_t kvm_get_cpuid_max_extended(void)
>> I would leave the existing function aside, and call this one
>> kvm_get_cpuid_max_amd() since CPUID leaves at 0x80000000 are allocated
>> by AMD.
> The existing function *is* the one that gives the largest
> AMD-allocated leaf.
Sorry about that---my fault for snipping the patch and assuming some
"git diff" craziness.
> Note that Intel documents CPUID.80000000:EAX as
> "Maximum Input Value for Extended Function CPUID Information," and AMD
> documents this as "Largest extended function."
Objection taken back, then!
Paolo
prev parent reply other threads:[~2019-10-10 16:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 0:41 [Patch 1/6] KVM: VMX: Remove unneeded check for X86_FEATURE_XSAVE Aaron Lewis
2019-10-09 0:41 ` [Patch 2/6] KVM: VMX: Use wrmsr for switching between guest and host IA32_XSS Aaron Lewis
2019-10-09 4:49 ` Yang Weijiang
2019-10-09 6:30 ` Paolo Bonzini
2019-10-09 12:34 ` Vitaly Kuznetsov
2019-10-09 6:31 ` Sebastian Andrzej Siewior
2019-10-09 0:41 ` [Patch 3/6] kvm: svm: Add support for XSAVES on AMD Aaron Lewis
2019-10-09 6:44 ` Sebastian Andrzej Siewior
2019-10-10 14:42 ` Aaron Lewis
2019-10-10 16:04 ` Paolo Bonzini
2019-10-09 7:01 ` Paolo Bonzini
2019-10-09 21:29 ` Jim Mattson
2019-10-09 21:40 ` Paolo Bonzini
2019-10-09 21:58 ` Jim Mattson
2019-10-09 22:49 ` Paolo Bonzini
2019-10-10 0:42 ` Kang, Luwei
2019-10-09 0:41 ` [Patch 4/6] kvm: svm: Enumerate XSAVES in guest CPUID when it is available to the guest Aaron Lewis
2019-10-09 1:42 ` Yang Weijiang
2019-10-09 6:32 ` Paolo Bonzini
2019-10-09 23:35 ` Jim Mattson
2019-10-09 0:41 ` [Patch 5/6] kvm: x86: Add IA32_XSS to the emulated_msrs list Aaron Lewis
2019-10-09 0:41 ` [Patch 6/6] kvm: tests: Add test to verify MSR_IA32_XSS Aaron Lewis
2019-10-09 6:30 ` Paolo Bonzini
2019-10-09 23:44 ` Jim Mattson
2019-10-10 16:01 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b9c6f5-9a9d-2ea1-ee84-19d2f5b83089@redhat.com \
--to=pbonzini@redhat.com \
--cc=Babu.Moger@amd.com \
--cc=aaronlewis@google.com \
--cc=bigeasy@linutronix.de \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=weijiang.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox