From: Janosch Frank <frankja@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: Andrew Jones <andrew.jones@linux.dev>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] Makefile: Move -no-pie from CFLAGS into LDFLAGS
Date: Tue, 22 Aug 2023 10:37:00 +0200 [thread overview]
Message-ID: <79f8ebd0-e4d0-5e28-f014-5ae0c1f2ec41@linux.ibm.com> (raw)
In-Reply-To: <20230822074906.7205-1-thuth@redhat.com>
On 8/22/23 09:49, Thomas Huth wrote:
> "-no-pie" is an option for linking, not for compiling, so we must put
> this into the lDFLAGS, not into CFLAGS. Without this change, the linking
> currently fails on Ubuntu 22.04 when compiling on a s390x host.
>
> Reported-by: Janosch Frank <frankja@linux.ibm.com>
> Fixes: e489c25e ("Rework the common LDFLAGS to become more useful again")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Just tested it on my system, this fixes the compile problem.
next prev parent reply other threads:[~2023-08-22 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:49 [kvm-unit-tests PATCH] Makefile: Move -no-pie from CFLAGS into LDFLAGS Thomas Huth
2023-08-22 8:07 ` Andrew Jones
2023-08-22 8:37 ` Janosch Frank [this message]
2023-08-22 9:28 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f8ebd0-e4d0-5e28-f014-5ae0c1f2ec41@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox