From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akio Takebe Subject: [Patch] cleanup warning of kvmctl.c Date: Fri, 19 Oct 2007 19:35:12 +0900 Message-ID: <7EC8123BBADDD6takebe_akio@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-devel Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, Nice to meet you, all. I recently got understanding kvm started, and I found some worning at compiling kvm. This patch is for cleanup of kvmctl.c. I tested Booting Linux guest on x86_32. Signed-off-by: Akio Takebe --- kvm-48.orig/user/kvmctl.c 2007-10-19 01:42:58.000000000 +0900 +++ kvm-48/user/kvmctl.c 2007-10-19 19:14:05.000000000 +0900 @@ -313,7 +313,7 @@ int kvm_alloc_kernel_memory(kvm_context_ struct kvm_memory_region above_4g_memory = { .slot = 4, .memory_size = memory < pcimem ? 0 : memory - pcimem, - .guest_phys_addr = 0x100000000, + .guest_phys_addr = 0x100000000ULL, }; if (memory >= pcimem) @@ -372,12 +372,12 @@ int kvm_alloc_userspace_memory(kvm_conte struct kvm_userspace_memory_region above_4g_memory = { .slot = 4, .memory_size = memory < pcimem ? 0 : memory - pcimem, - .guest_phys_addr = 0x100000000, + .guest_phys_addr = 0x100000000ULL, }; if (memory >= pcimem) { extended_memory.memory_size = pcimem - exmem; - *vm_mem = mmap(NULL, memory + 0x100000000 - pcimem, + *vm_mem = mmap(NULL, memory + 0x100000000ULL - pcimem, PROT_READ|PROT_WRITE, MAP_ANONYMOUS | MAP_SHARED, -1, 0); } @@ -413,13 +413,13 @@ int kvm_alloc_userspace_memory(kvm_conte } if (above_4g_memory.memory_size) { - r = munmap(*vm_mem + pcimem, 0x100000000 - pcimem); + r = munmap(*vm_mem + pcimem, 0x100000000ULL - pcimem); if (r == -1) { fprintf(stderr, "kvm_alloc_userspace_memory: %s", strerror(errno)); return -1; } - above_4g_memory.userspace_addr = (unsigned long)(*vm_mem + 0x100000000); + above_4g_memory.userspace_addr = (unsigned long)(*vm_mem + 0x100000000ULL); r = ioctl(kvm->vm_fd, KVM_SET_USER_MEMORY_REGION, &above_4g_memory); if (r == -1) { fprintf(stderr, "kvm_create_memory_region: %m\n"); ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/