* Problems with uio_pci_generic in v4.18-rc8
@ 2018-08-10 21:12 Harris, James R
2018-08-12 10:55 ` Xiubo Li
0 siblings, 1 reply; 4+ messages in thread
From: Harris, James R @ 2018-08-10 21:12 UTC (permalink / raw)
To: gregkh@linuxfoundation.org, xiubli@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael S. Tsirkin, Jiang, Dave, Walker, Benjamin,
Wodkowski, PawelX
Hi,
Using Linux kernel v4.18-rc8, I am unable to bind a PCI device to uio_pci_generic. This works fine with v4.18-rc4. dmesg shows:
[ 336.221585] genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 33
[ 336.221681] uio_pci_generic: probe of 0000:04:00.0 failed with error -22
This problem has been reproduced on multiple systems.
This seems to be related to commit 9421e45f5 (“uio: use request_threaded_irq instead”) which was merged in -rc5. Reverting this commit fixes the issue (I also reverted 543af5861f and 57c5f4df0a which also touch uio.c - just to be safe).
This seems like a serious regression to uio_pci_generic, but any tips or pointers would be appreciated.
Thanks,
Jim Harris
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Problems with uio_pci_generic in v4.18-rc8
2018-08-10 21:12 Problems with uio_pci_generic in v4.18-rc8 Harris, James R
@ 2018-08-12 10:55 ` Xiubo Li
2018-08-12 11:03 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: Xiubo Li @ 2018-08-12 10:55 UTC (permalink / raw)
To: Harris, James R, gregkh@linuxfoundation.org
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael S. Tsirkin, Jiang, Dave, Walker, Benjamin,
Wodkowski, PawelX
Hi Harris,
Since the lock protection in uio irq handler is useless currently as
discussed in the mail list, so I will revert this commit with small
changes and now the testing based LIO/TCMU has been finished.
Thanks,
BRs
On 2018/8/11 5:12, Harris, James R wrote:
> Hi,
>
> Using Linux kernel v4.18-rc8, I am unable to bind a PCI device to uio_pci_generic. This works fine with v4.18-rc4. dmesg shows:
>
> [ 336.221585] genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 33
> [ 336.221681] uio_pci_generic: probe of 0000:04:00.0 failed with error -22
>
> This problem has been reproduced on multiple systems.
>
> This seems to be related to commit 9421e45f5 (“uio: use request_threaded_irq instead”) which was merged in -rc5. Reverting this commit fixes the issue (I also reverted 543af5861f and 57c5f4df0a which also touch uio.c - just to be safe).
>
> This seems like a serious regression to uio_pci_generic, but any tips or pointers would be appreciated.
>
> Thanks,
>
> Jim Harris
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Problems with uio_pci_generic in v4.18-rc8
2018-08-12 10:55 ` Xiubo Li
@ 2018-08-12 11:03 ` gregkh
2018-08-12 11:45 ` Xiubo Li
0 siblings, 1 reply; 4+ messages in thread
From: gregkh @ 2018-08-12 11:03 UTC (permalink / raw)
To: Xiubo Li
Cc: Harris, James R, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael S. Tsirkin, Jiang, Dave,
Walker, Benjamin, Wodkowski, PawelX
On Sun, Aug 12, 2018 at 06:55:58PM +0800, Xiubo Li wrote:
> Hi Harris,
>
> Since the lock protection in uio irq handler is useless currently as
> discussed in the mail list, so I will revert this commit with small changes
> and now the testing based LIO/TCMU has been finished.
Can you send the fixup patch so I can apply it please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Problems with uio_pci_generic in v4.18-rc8
2018-08-12 11:03 ` gregkh
@ 2018-08-12 11:45 ` Xiubo Li
0 siblings, 0 replies; 4+ messages in thread
From: Xiubo Li @ 2018-08-12 11:45 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: Harris, James R, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael S. Tsirkin, Jiang, Dave,
Walker, Benjamin, Wodkowski, PawelX
On 2018/8/12 19:03, gregkh@linuxfoundation.org wrote:
> On Sun, Aug 12, 2018 at 06:55:58PM +0800, Xiubo Li wrote:
>> Hi Harris,
>>
>> Since the lock protection in uio irq handler is useless currently as
>> discussed in the mail list, so I will revert this commit with small changes
>> and now the testing based LIO/TCMU has been finished.
> Can you send the fixup patch so I can apply it please?
Yeah, sure.
Thanks,
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-12 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-10 21:12 Problems with uio_pci_generic in v4.18-rc8 Harris, James R
2018-08-12 10:55 ` Xiubo Li
2018-08-12 11:03 ` gregkh
2018-08-12 11:45 ` Xiubo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).