From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F28BC433ED for ; Fri, 14 May 2021 08:03:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07179613B5 for ; Fri, 14 May 2021 08:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233386AbhENIEg (ORCPT ); Fri, 14 May 2021 04:04:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30984 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbhENIEf (ORCPT ); Fri, 14 May 2021 04:04:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620979404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FE60io7r9QIWZ+2HbVfZ7x5W1zNu5ip9FIeLOvLYCnU=; b=hKnglwiQ/e1b+A81eWrL0WKkejcnMbR4/NtxDKvNPEeM7S5S8BvV7AjvvomVxc4kSRA9Yy MPbrZ+QelYFxAi9CIOv3Cn21UuX7gWw4wMWqpZsqXbw6Zky+MqYSJywU1OtYXT6Q/9MklW sAhXOjjNKOIwO6eQRv8i7VqqmCxnskc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-fpNaA0aJO_enMy5P119Oaw-1; Fri, 14 May 2021 04:03:22 -0400 X-MC-Unique: fpNaA0aJO_enMy5P119Oaw-1 Received: by mail-ej1-f69.google.com with SMTP id h4-20020a1709067184b02903cbbd4c3d8fso4474982ejk.6 for ; Fri, 14 May 2021 01:03:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FE60io7r9QIWZ+2HbVfZ7x5W1zNu5ip9FIeLOvLYCnU=; b=CxKK4zuWG5HpzpxqLnFBgBKeCygOaRQ4yj/nCXYW9zA2qz/JcIIfGGAUpqZsZodIiw Xk+lfCqUZyb0FDSeiRBh0hL3kYufowCz3eK9cfteKkqdvfQbSSeA+WEOnh8FIBsVqxqR uYmQ+WEcOZ8VnOUxxknoSWCrb4Kl1Vh1OamxMK0o7KJ2+DyC9DMyyY/zBEgnN9/s20Rv OMEaB905lM2unKbPmKp9dOTv9Vo1ASbjQgE3DQLTlve9GwytUlYBMfqD2d0IMuBc9es3 GrSM5k+2Rp9QopM+5v4GiKsK5rKrWtu5vNtrVRJJcUzirHd35eKVobz2zVkBEE8z4k/7 kqJQ== X-Gm-Message-State: AOAM531ARqjcs0hzWjARgoZWQQ7+1beS7Ydk0pXAirqI9iAUx0DHqhyz ZukUFBy/8dPY11o2GRDOd8UQsl9o7lxk1LCDK9EGctwCpflY5cyya012bCixmQkMzUt34pHYY9a SUpmVEtQuhi3Y X-Received: by 2002:aa7:c510:: with SMTP id o16mr54472575edq.310.1620979401405; Fri, 14 May 2021 01:03:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpDHOVkmNABs2GYteK1qO1NoUOqEFLYflF2NqT3dOmyL4hm384XqS1YbGvZOdh0vIVvk7JBg== X-Received: by 2002:aa7:c510:: with SMTP id o16mr54472550edq.310.1620979401260; Fri, 14 May 2021 01:03:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id w19sm4020166edd.52.2021.05.14.01.03.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 01:03:20 -0700 (PDT) Subject: Re: [PATCH v2 2/4] mm: x86: Invoke hypercall when page encryption status is changed To: Borislav Petkov , Ashish Kalra Cc: seanjc@google.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com References: <20210513043441.GA28019@ashkalra_ubuntu_server> From: Paolo Bonzini Message-ID: <7ac12a36-5886-cb07-cc77-a96daa76b854@redhat.com> Date: Fri, 14 May 2021 10:03:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 14/05/21 09:33, Borislav Petkov wrote: > Ok, so explain to me how this looks from the user standpoint: she starts > migrating the guest, it fails to lookup an address, there's nothing > saying where it failed but the guest crashed. > > Do you think this is user-friendly? Ok, so explain to me how this looks from the submitter standpoint: he reads your review of his patch, he acknowledges your point with "Yes, it makes sense to signal it with a WARN or so", and still is treated as shit. Do you think this is friendly? Paolo