From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14EFC433DF for ; Fri, 29 May 2020 10:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD46F207BC for ; Fri, 29 May 2020 10:48:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QlUXb8gP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgE2Ksg (ORCPT ); Fri, 29 May 2020 06:48:36 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27039 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725863AbgE2Ksb (ORCPT ); Fri, 29 May 2020 06:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590749310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lZTwXys9JODCXs4XiXlRjVl8buJ25dhhOGvmDlLOBA=; b=QlUXb8gPM5ubmh6V1tHtQxkwmPRb+ayl1NJIvktYhScvwr5gzr+H9goewzztG5u4MXKh3K Qq5FsbaRLMkJMQZ4u9QmzlNHXkCKruJnODWBPgJhG/l9V6KVkOA8RUg9XWd03REzEkjw3O M4xTsGTH1QfxUTeeG4CeTwEubXlEMng= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-eJiAEbmIMqWkGdKZDZ8dQQ-1; Fri, 29 May 2020 06:48:28 -0400 X-MC-Unique: eJiAEbmIMqWkGdKZDZ8dQQ-1 Received: by mail-wm1-f72.google.com with SMTP id 11so626839wmj.6 for ; Fri, 29 May 2020 03:48:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9lZTwXys9JODCXs4XiXlRjVl8buJ25dhhOGvmDlLOBA=; b=gbt1W3sTCAYw2rnoLergSpTYBBVDCh2n310D+I1K+siV0diASpNYXrEnFSFz7i47Oa 4lpf4SQQokM7k2AXHuzshs0MzLsIA0FeMII80v4uArwcF7MW0JN9uAoumoEmXY94MvpL RUuehFEHVHbuNLwtzUF3RUxO61DXD+/0uJUEKpbf3x4zkulLwcqVsyQPc5pf40/OhY1H iNyiRojWr7+BBSmHOyYYx0Lo+IEUtDqn56b+fElxxQgTi5rejTPCZkj7KyM1dKisiiq1 eqjWY43ayq7JGBa8ngFMPkLlG7UtHmryf9LbibdSpSTI4VHDuNHYvF+TGKNw6ejBqg1X BKyg== X-Gm-Message-State: AOAM533HTva6CqG6WKsgoTs9Nl83hoF8GNmseDNjYeQjlahGbf48xdUN nxScd/6m0/47vxS9kSjJ27vF7DmZOicF8NNjUR2YDUaXtMYisVQtVHBrr4TqEOKP05jAbPg69Jf 7X+VP2n/lwh7T X-Received: by 2002:adf:ea8b:: with SMTP id s11mr8318354wrm.168.1590749307143; Fri, 29 May 2020 03:48:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq5ZFwQJ+jQLcj8SlKA74AIKEYwZxYdLQNJdwXmzuehZryK6oNdOxBvH2VRvGqurWBH55Plw== X-Received: by 2002:adf:ea8b:: with SMTP id s11mr8318340wrm.168.1590749306948; Fri, 29 May 2020 03:48:26 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:b096:1b7:7695:e4f7? ([2001:b07:6468:f312:b096:1b7:7695:e4f7]) by smtp.gmail.com with ESMTPSA id k21sm5167153wrd.24.2020.05.29.03.48.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 03:48:26 -0700 (PDT) Subject: Re: [PATCH v11 5/7] x86/kvm/hyper-v: enable hypercalls without hypercall page with syndbg To: Jon Doron , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org Cc: vkuznets@redhat.com References: <20200424113746.3473563-1-arilou@gmail.com> <20200424113746.3473563-6-arilou@gmail.com> From: Paolo Bonzini Message-ID: <7ad6cc8a-7c4a-f556-4f59-704234ce73cb@redhat.com> Date: Fri, 29 May 2020 12:48:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200424113746.3473563-6-arilou@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 24/04/20 13:37, Jon Doron wrote: > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index 435516595090..524b5466a515 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -1650,7 +1650,10 @@ static u64 kvm_hv_send_ipi(struct kvm_vcpu *current_vcpu, u64 ingpa, u64 outgpa, > > bool kvm_hv_hypercall_enabled(struct kvm *kvm) > { > - return READ_ONCE(kvm->arch.hyperv.hv_hypercall) & HV_X64_MSR_HYPERCALL_ENABLE; > + struct kvm_hv *hv = &kvm->arch.hyperv; > + > + return READ_ONCE(hv->hv_hypercall) & HV_X64_MSR_HYPERCALL_ENABLE || > + (hv->hv_syndbg.active && READ_ONCE(hv->hv_guest_os_id) != 0); > } Here too we could just shrug and allow hypercalls if the guest OS is not NULL. Paolo