From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH kvm-unit-tests v2 00/12] arm/arm64: mmu fixes and feature Date: Wed, 17 Jan 2018 12:17:12 +0100 Message-ID: <7b935627-17f4-2eef-ebe1-3e26919e21a7@redhat.com> References: <20180117104005.29211-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, rkrcmar@redhat.com, cdall@linaro.org, lvivier@redhat.com, thuth@redhat.com To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36818 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbeAQLRP (ORCPT ); Wed, 17 Jan 2018 06:17:15 -0500 In-Reply-To: <20180117104005.29211-1-drjones@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 17.01.2018 11:39, Andrew Jones wrote: > The fixes are getting tests to run on 32-bit ARM again and also > fixing virt_to_phys(). The feature is to allow a unit test to start > with the MMU disabled. Couple minor cleanups thrown in too. > > I tested x86 and ppc64 over TCG, but not s390 (please-test: David). > > v2: > - fix compiling on s390x by adding bitops/fls [reported by David] > - fix page_memalign order calculation for non-power-of-2 number of > pages (need to round up) [drew] PASS selftest-setup (14 tests) FAIL intercept (20 tests, 3 unexpected failures) PASS emulator (89 tests, 1 skipped) PASS sieve Which is expected on my version of QEMU s390x tcg. So virtual memory access still works fine. > > Andrew Jones (12): > arm/arm64: cleanup alloc.h includes > arm/arm64: add pgtable to thread_info > arm/arm64: fix virt_to_phys > arm/arm64: flush page table cache when installing entries > arm/arm64: setup: don't allow gaps in phys range > phys_alloc: ensure we account all allocations > page_alloc: allow initialization before setup_vm call > bitops: add fls > page_alloc: add yet another memalign > lib/auxinfo: add flags field > arm/arm64: allow setup_vm to be skipped > arm/arm64: sieve should start with the mmu off > > arm/Makefile.common | 5 ++++- > arm/cstart.S | 19 ++++++++++++++++++- > arm/cstart64.S | 17 ++++++++++++++++- > lib/alloc_page.c | 36 ++++++++++++++++++++++++++++++++++++ > lib/alloc_page.h | 2 ++ > lib/alloc_phys.c | 10 ++++++++++ > lib/alloc_phys.h | 6 ++++-- > lib/arm/asm/bitops.h | 2 ++ > lib/arm/asm/mmu.h | 5 +++++ > lib/arm/asm/page.h | 8 +++----- > lib/arm/asm/pgtable.h | 16 ++++++++++++---- > lib/arm/asm/setup.h | 1 - > lib/arm/asm/thread_info.h | 1 + > lib/arm/mmu.c | 43 ++++++++++++++++++++++++++++++++++++++----- > lib/arm/processor.c | 1 + > lib/arm/setup.c | 22 ++++++++++++++-------- > lib/arm/smp.c | 7 ++++++- > lib/arm64/asm/bitops.h | 2 ++ > lib/arm64/asm/mmu.h | 5 +++++ > lib/arm64/asm/page.h | 10 +++------- > lib/arm64/asm/pgtable.h | 12 ++++++++++-- > lib/arm64/processor.c | 1 + > lib/arm64/spinlock.c | 1 + > lib/auxinfo.c | 13 ++++++++++++- > lib/auxinfo.h | 6 ++++++ > lib/bitops.h | 38 ++++++++++++++++++++++++++++++++++++++ > lib/ppc64/asm/bitops.h | 2 ++ > lib/s390x/asm/bitops.h | 10 ++++++++++ > lib/vmalloc.c | 9 ++++++--- > lib/x86/asm/bitops.h | 2 ++ > 30 files changed, 270 insertions(+), 42 deletions(-) > create mode 100644 lib/s390x/asm/bitops.h > -- Thanks, David / dhildenb