From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "sashiko-reviews@lists.linux.dev" <sashiko-reviews@lists.linux.dev>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v8 06/11] KVM: TDX: Allocate PAMT memory for TD and vCPU control structures
Date: Wed, 29 Jul 2026 22:05:59 +0000 [thread overview]
Message-ID: <7bd02e4c440302ececb86f6a3b875efafd977c16.camel@intel.com> (raw)
In-Reply-To: <20260725003525.5A10B1F00A3A@smtp.kernel.org>
On Sat, 2026-07-25 at 00:35 +0000, sashiko-bot@kernel.org wrote:
> [Severity: High]
> This is a pre-existing issue, but does taking cpus_read_lock() inside this
> function create an ABBA deadlock risk?
>
> Looking at __tdx_td_init(), just a few lines below this allocation loop, the
> code calls cpus_read_lock():
As Sashiko says, this is a pre-existing issue. But also already discussed here:
https://lore.kernel.org/kvm/ak5L2csITyi1tGp0@google.com/
It makes me wonder what what we can do about repeated Sashiko false positives.
next prev parent reply other threads:[~2026-07-29 22:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 0:22 [PATCH v8 00/11] Dynamic PAMT Rick Edgecombe
2026-07-25 0:22 ` [PATCH v8 01/11] x86/virt/tdx: Simplify PAMT layout calculation Rick Edgecombe
2026-07-25 0:22 ` [PATCH v8 02/11] x86/virt/tdx: Allocate page bitmap for Dynamic PAMT Rick Edgecombe
2026-07-25 0:33 ` sashiko-bot
2026-07-29 22:14 ` Edgecombe, Rick P
2026-07-25 0:22 ` [PATCH v8 03/11] x86/virt/tdx: Add tdx_alloc/free_control_page() helpers Rick Edgecombe
2026-07-25 0:35 ` sashiko-bot
2026-07-29 22:10 ` Edgecombe, Rick P
2026-07-25 0:22 ` [PATCH v8 04/11] x86/virt/tdx: Allocate refcounts for Dynamic PAMT memory Rick Edgecombe
2026-07-25 0:22 ` [PATCH v8 05/11] x86/virt/tdx: Handle multiple callers in tdx_pamt_get/put() Rick Edgecombe
2026-07-25 0:22 ` [PATCH v8 06/11] KVM: TDX: Allocate PAMT memory for TD and vCPU control structures Rick Edgecombe
2026-07-25 0:35 ` sashiko-bot
2026-07-29 22:05 ` Edgecombe, Rick P [this message]
2026-07-25 0:22 ` [PATCH v8 07/11] x86/tdx: Add APIs to support Dynamic PAMT ops from KVM's fault path Rick Edgecombe
2026-07-25 0:22 ` [PATCH v8 08/11] KVM: TDX: Get/put PAMT pages when (un)mapping private memory Rick Edgecombe
2026-07-25 0:46 ` sashiko-bot
2026-07-29 22:06 ` Edgecombe, Rick P
2026-07-25 0:22 ` [PATCH v8 09/11] x86/virt/tdx: Enable Dynamic PAMT Rick Edgecombe
2026-07-25 0:23 ` [PATCH v8 10/11] Documentation/x86: Add documentation for TDX's " Rick Edgecombe
2026-07-25 0:23 ` [PATCH v8 11/11] x86/virt/tdx: Optimize tdx_pamt_get/put() Rick Edgecombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd02e4c440302ececb86f6a3b875efafd977c16.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox