From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, rkrcmar@redhat.com, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 0/3] arm/powerpc: make argv[0] the program name
Date: Tue, 14 Jun 2016 16:45:31 +0200 [thread overview]
Message-ID: <7be67e69-e9f4-ec88-7e4d-c62d0089bd2d@redhat.com> (raw)
In-Reply-To: <20160614144038.tg7dgq42p2wbstpe@hawk.localdomain>
On 14/06/2016 16:40, Andrew Jones wrote:
>
> Hi Paolo,
>
> Can you take a look at this series?
Yes, I wanted to find a little tomorrow to push x86 argv down by one
item and then apply it.
Paolo
> Thanks,
> drew
>
>
> On Sun, Jun 12, 2016 at 07:29:28PM +0200, Andrew Jones wrote:
>> v3:
>> - fixed x86 compilation by adding a weak symbol for auxinfo
>> - reworked all patches to avoid the ugly, although temporary, #ifdeffery
>> - also squashed patches 3/4 and 4/4 together
>> - moved initializer out of for() [Thomas]
>> - dropped all of Thomas' r-b's, as I changed too much to keep
>> them, but he shouldn't need to review much of the two "reserve..."
>> patches again.
>>
>> repost:
>> - rebased to latest upstream master (fixed trivial conflicts
>> with 4c6b5d and dc0a22, the Makefile cleanup patches)
>> - added Thomas' r-b's
>> v2:
>> - copy auxinfo.prognam into argv[0] [drew]
>>
>>
>> It just came to my attention that x86 has the normal argv[0], the
>> program name, thanks to seabios. That raised the priority of fixing
>> one of my pet peeves - arm and powerpc starting arguments
>> at argv[0], as that just ain't right. This series fixes that. A few
>> temporary hacks are used to avoid one big patch fixing both arm
>> and powerpc at the same time. The hacks are gone by the end of the
>> series.
>>
>>
>> Andrew Jones (3):
>> arm/arm64: reserve argv[0] for prognam
>> powerpc/ppc64: reserve argv[0] for prognam
>> arm & powerpc: populate argv[0] with prognam
>>
>> arm/Makefile.common | 6 +++++-
>> arm/selftest.c | 14 +++++++-------
>> arm/spinlock-test.c | 2 +-
>> lib/argv.c | 27 +++++++++++++++++++++++----
>> lib/arm/setup.c | 4 ++--
>> lib/auxinfo.c | 2 ++
>> lib/auxinfo.h | 7 +++++++
>> lib/powerpc/setup.c | 4 ++--
>> powerpc/Makefile.common | 6 +++++-
>> powerpc/emulator.c | 2 +-
>> powerpc/rtas.c | 12 ++++++------
>> powerpc/selftest.c | 8 ++++----
>> powerpc/spapr_hcall.c | 6 +++---
>> scripts/auxinfo.mak | 7 +++++++
>> x86/Makefile.common | 1 +
>> 15 files changed, 76 insertions(+), 32 deletions(-)
>> create mode 100644 lib/auxinfo.c
>> create mode 100644 lib/auxinfo.h
>> create mode 100755 scripts/auxinfo.mak
>>
>> --
>> 2.4.11
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kvm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-14 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 17:29 [kvm-unit-tests PATCH v3 0/3] arm/powerpc: make argv[0] the program name Andrew Jones
2016-06-12 17:29 ` [kvm-unit-tests PATCH v3 1/3] arm/arm64: reserve argv[0] for prognam Andrew Jones
2016-06-13 11:13 ` Thomas Huth
2016-06-13 14:12 ` Laurent Vivier
2016-06-12 17:29 ` [kvm-unit-tests PATCH v3 2/3] powerpc/ppc64: " Andrew Jones
2016-06-13 11:18 ` Thomas Huth
2016-06-13 14:16 ` Laurent Vivier
2016-06-12 17:29 ` [kvm-unit-tests PATCH v3 3/3] arm & powerpc: populate argv[0] with prognam Andrew Jones
2016-06-13 14:24 ` Laurent Vivier
2016-06-13 16:09 ` Thomas Huth
2016-07-11 13:05 ` Paolo Bonzini
2016-07-11 13:50 ` Andrew Jones
2016-07-11 14:08 ` Paolo Bonzini
2016-07-12 8:22 ` Andrew Jones
2016-07-12 10:26 ` Paolo Bonzini
2016-06-14 14:40 ` [kvm-unit-tests PATCH v3 0/3] arm/powerpc: make argv[0] the program name Andrew Jones
2016-06-14 14:45 ` Paolo Bonzini [this message]
2016-06-29 11:32 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7be67e69-e9f4-ec88-7e4d-c62d0089bd2d@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox