From: Binbin Wu <binbin.wu@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Paul Durrant <paul@xen.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosry@kernel.org>
Subject: Re: [PATCH 07/11] KVM: x86: Add mode-aware versions of kvm_<reg>_{read,write}() helpers
Date: Tue, 14 Apr 2026 17:02:22 +0800 [thread overview]
Message-ID: <7c1afcda-5a7d-40b6-a992-5f38caa80462@linux.intel.com> (raw)
In-Reply-To: <20260409235622.2052730-8-seanjc@google.com>
On 4/10/2026 7:56 AM, Sean Christopherson wrote:
[...]
> @@ -2542,18 +2542,18 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu)
>
> #ifdef CONFIG_X86_64
> if (is_64_bit_hypercall(vcpu)) {
> - hc.param = kvm_rcx_read(vcpu);
> - hc.ingpa = kvm_rdx_read(vcpu);
> - hc.outgpa = kvm_r8_read(vcpu);
> + hc.param = kvm_rcx_read_raw(vcpu);
> + hc.ingpa = kvm_rdx_read_raw(vcpu);
> + hc.outgpa = kvm_r8_read_raw(vcpu);
> } else
> #endif
> {
> - hc.param = ((u64)kvm_rdx_read(vcpu) << 32) |
> - (kvm_rax_read(vcpu) & 0xffffffff);
> - hc.ingpa = ((u64)kvm_rbx_read(vcpu) << 32) |
> - (kvm_rcx_read(vcpu) & 0xffffffff);
> - hc.outgpa = ((u64)kvm_rdi_read(vcpu) << 32) |
> - (kvm_rsi_read(vcpu) & 0xffffffff);
> + hc.param = ((u64)kvm_rdx_read_raw(vcpu) << 32) |
> + (kvm_rdx_read_raw(vcpu) & 0xffffffff);
> + hc.ingpa = ((u64)kvm_rdx_read_raw(vcpu) << 32) |
> + (kvm_rdx_read_raw(vcpu) & 0xffffffff);
> + hc.outgpa = ((u64)kvm_rdx_read_raw(vcpu) << 32) |
> + (kvm_rdx_read_raw(vcpu) & 0xffffffff);
All registers become RDX, which seems not right.
Also, should "e" versions used here?
> }
>
> hc.code = hc.param & 0xffff;
[...]
next prev parent reply other threads:[~2026-04-14 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 23:56 [PATCH 00/11] KVM: x86: Clean up kvm_<reg>_{read,write}() mess Sean Christopherson
2026-04-09 23:56 ` [PATCH 01/11] KVM: SVM: Truncate INVLPGA address in compatibility mode Sean Christopherson
2026-04-09 23:56 ` [PATCH 02/11] KVM: x86/xen: Bug the VM if 32-bit KVM observes a 64-bit mode hypercall Sean Christopherson
2026-04-09 23:56 ` [PATCH 03/11] KVM: x86/xen: Don't truncate RAX when handling hypercall from protected guest Sean Christopherson
2026-04-13 10:36 ` Binbin Wu
2026-04-09 23:56 ` [PATCH 04/11] KVM: VMX: Read 32-bit GPR values for ENCLS instructions outside of 64-bit mode Sean Christopherson
2026-04-13 12:19 ` Huang, Kai
2026-04-09 23:56 ` [PATCH 05/11] KVM: x86: Trace hypercall register *after* truncating values for 32-bit Sean Christopherson
2026-04-09 23:56 ` [PATCH 06/11] KVM: x86: Move kvm_<reg>_{read,write}() definitions to x86.h Sean Christopherson
2026-04-09 23:56 ` [PATCH 07/11] KVM: x86: Add mode-aware versions of kvm_<reg>_{read,write}() helpers Sean Christopherson
2026-04-14 8:26 ` Huang, Kai
2026-04-14 15:42 ` Sean Christopherson
2026-04-14 9:02 ` Binbin Wu [this message]
2026-04-09 23:56 ` [PATCH 08/11] KVM: x86: Drop non-raw kvm_<reg>_write() helpers Sean Christopherson
2026-04-09 23:56 ` [PATCH 09/11] KVM: nSVM: Use kvm_rax_read() now that it's mode-aware Sean Christopherson
2026-04-09 23:56 ` [PATCH 10/11] Revert "KVM: VMX: Read 32-bit GPR values for ENCLS instructions outside of 64-bit mode" Sean Christopherson
2026-04-09 23:56 ` [PATCH 11/11] KVM: x86: Harden is_64_bit_hypercall() against bugs on 32-bit kernels Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1afcda-5a7d-40b6-a992-5f38caa80462@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox