From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9D5C4332F for ; Wed, 21 Dec 2022 13:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234589AbiLUN2H (ORCPT ); Wed, 21 Dec 2022 08:28:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234491AbiLUN12 (ORCPT ); Wed, 21 Dec 2022 08:27:28 -0500 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCA2CDE5 for ; Wed, 21 Dec 2022 05:26:56 -0800 (PST) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1322d768ba7so19160108fac.5 for ; Wed, 21 Dec 2022 05:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sfAx5V1o1e/QdKHDl+1bc+xUXDa6fYhV+plOxuA3aLU=; b=TB1ijPDYtOSaO3IZyGxMDT/6TdAnpolPx4fLsdc8SA71rFwP1skxv4IsCc55qHIxu+ NClrSfUmJOlZeHUR3QkbC54WbwdOFMDhsQ6zIn/FCHGDle0mrScIiCHPOgbRulCG4xj/ 7vMT3GCKx88q0S1cTCsvI68p/mgmKd8r/qhOJ2ntPBv06dg6zzHhVRbhugcoqPXD08gP rzfzIf+ql8UTAL54vWTUIhOljBMw1VEAyOcZmlM2f1aC7lzis1qIt/bchYqB14n4Mw+g X4tRLY/lJzvlvgtAJW3/eZOa380HOOelg6Qo+Gu8rQYwLodrnu+ivY1OhMQH7NYbEwhT KK9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sfAx5V1o1e/QdKHDl+1bc+xUXDa6fYhV+plOxuA3aLU=; b=KDSekoT+7nAc7D64+DdJfTyFwOBp+cC3WbFPTKzq8M4AbhFYYTuYkvDtv/aI9kJrSo zQpk46ep+GrTtGoGnwgaGicpQRSaPM8LVJ847uL60lPr5+BHv5VYJSqBlc9LL3zxvuIw 3k1lTud/ncBSm4oFUNHgeELYGCXUsZgmdnbQmhLxJt2B/2Rq9ynnVDsLor4svgcB3okp CeXbokDLn8t44WVfTfS2uE2eYV/+dY/ONgHZVKurk/kaGLEB+pWKpS8CPC7CvGaDq5B1 WRzM/tebxrxyhMputVa576jZRtBjFIlENv6lG5u08i+xwng1D7wC1jxN63SKwF8yBpk6 hOAg== X-Gm-Message-State: AFqh2krWAhr/kBMY2r2miVPx5qO7rQDZJgMFNzjoq7qoZb0uFiT6wYGf /gUAXxdfxsrUOANTsWnb1jI= X-Google-Smtp-Source: AMrXdXtIWCAc/Brt99I1yXYQ8Xd5LCkRdCPuf4H7uKUWRmqQjsFd1UpmWmuwoIruy1wunRiRtqjyZQ== X-Received: by 2002:a05:6871:458f:b0:144:df53:a4f6 with SMTP id nl15-20020a056871458f00b00144df53a4f6mr742685oab.10.1671629216186; Wed, 21 Dec 2022 05:26:56 -0800 (PST) Received: from [192.168.68.106] (201-43-103-101.dsl.telesp.net.br. [201.43.103.101]) by smtp.gmail.com with ESMTPSA id i3-20020a056870890300b001446d5702b5sm7193582oao.56.2022.12.21.05.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 05:26:55 -0800 (PST) Message-ID: <7c67f0e8-f7b7-8d0d-ba72-06cd2c8d29d3@gmail.com> Date: Wed, 21 Dec 2022 10:26:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH-for-8.0 4/4] hw/ppc/spapr_ovec: Avoid target_ulong spapr_ovec_parse_vector() Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-ppc@nongnu.org, David Gibson , kvm@vger.kernel.org, Alexey Kardashevskiy , Greg Kurz , Paolo Bonzini , Markus Armbruster References: <20221213123550.39302-1-philmd@linaro.org> <20221213123550.39302-5-philmd@linaro.org> <5f70da81-2854-766f-1804-59a037a605b8@kaod.org> From: Daniel Henrique Barboza In-Reply-To: <5f70da81-2854-766f-1804-59a037a605b8@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/21/22 06:46, Cédric Le Goater wrote: > On 12/16/22 17:47, Daniel Henrique Barboza wrote: >> >> >> On 12/13/22 09:35, Philippe Mathieu-Daudé wrote: >>> spapr_ovec.c is a device, but it uses target_ulong which is >>> target specific. The hwaddr type (declared in "exec/hwaddr.h") >>> better fits hardware addresses. >> >> As said by Harsh, spapr_ovec is in fact a data structure that stores platform >> options that are supported by the guest. >> >> That doesn't mean that I oppose the change made here. Aside from semantics - which >> I also don't have a strong opinion about it - I don't believe it matters that >> much - spapr is 64 bit only, so hwaddr will always be == target_ulong. >> >> Cedric/David/Greg, let me know if you have any restriction/thoughts about this. >> I'm inclined to accept it as is. > > Well, I am not sure. > > The vector table variable is the result of a ppc64_phys_to_real() conversion > of the CAS hcall parameter, which is a target_ulong, but ppc64_phys_to_real() > returns a uint64_t. > > The code is not consistent in another places : > >   hw/ppc/spapr_tpm_proxy.c uses a uint64_t >   hw/ppc/spapr_hcall.c, a target_ulong >   hw/ppc/spapr_rtas.c, a hwaddr >   hw/ppc/spapr_drc.c, a hwaddr indirectly > > Should we change ppc64_phys_to_real() to return an hwaddr (also) ? It makes sense to me a function called ppc64_phys_to_real() returning a hwaddr type. Daniel > > C. > > >> >> >> Daniel >> >>> >>> Change spapr_ovec_parse_vector() to take a hwaddr argument, >>> allowing the removal of "cpu.h" in a device header. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>   hw/ppc/spapr_ovec.c         | 3 ++- >>>   include/hw/ppc/spapr_ovec.h | 4 ++-- >>>   2 files changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/hw/ppc/spapr_ovec.c b/hw/ppc/spapr_ovec.c >>> index b2567caa5c..a18a751b57 100644 >>> --- a/hw/ppc/spapr_ovec.c >>> +++ b/hw/ppc/spapr_ovec.c >>> @@ -19,6 +19,7 @@ >>>   #include "qemu/error-report.h" >>>   #include "trace.h" >>>   #include >>> +#include "cpu.h" >>>   #define OV_MAXBYTES 256 /* not including length byte */ >>>   #define OV_MAXBITS (OV_MAXBYTES * BITS_PER_BYTE) >>> @@ -176,7 +177,7 @@ static target_ulong vector_addr(target_ulong table_addr, int vector) >>>       return table_addr; >>>   } >>> -SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector) >>> +SpaprOptionVector *spapr_ovec_parse_vector(hwaddr table_addr, int vector) >>>   { >>>       SpaprOptionVector *ov; >>>       target_ulong addr; >>> diff --git a/include/hw/ppc/spapr_ovec.h b/include/hw/ppc/spapr_ovec.h >>> index c3e8b98e7e..d756b916e4 100644 >>> --- a/include/hw/ppc/spapr_ovec.h >>> +++ b/include/hw/ppc/spapr_ovec.h >>> @@ -37,7 +37,7 @@ >>>   #ifndef SPAPR_OVEC_H >>>   #define SPAPR_OVEC_H >>> -#include "cpu.h" >>> +#include "exec/hwaddr.h" >>>   typedef struct SpaprOptionVector SpaprOptionVector; >>> @@ -73,7 +73,7 @@ void spapr_ovec_set(SpaprOptionVector *ov, long bitnr); >>>   void spapr_ovec_clear(SpaprOptionVector *ov, long bitnr); >>>   bool spapr_ovec_test(SpaprOptionVector *ov, long bitnr); >>>   bool spapr_ovec_empty(SpaprOptionVector *ov); >>> -SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector); >>> +SpaprOptionVector *spapr_ovec_parse_vector(hwaddr table_addr, int vector); >>>   int spapr_dt_ovec(void *fdt, int fdt_offset, >>>                     SpaprOptionVector *ov, const char *name); >