From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Liu <jing2.liu@linux.intel.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jing2.liu@intel.com
Subject: Re: [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest
Date: Mon, 24 Jun 2019 10:33:37 +0200 [thread overview]
Message-ID: <7d304ae7-73c0-d2a9-cd3e-975941a91266@redhat.com> (raw)
In-Reply-To: <fb749626-1d9e-138f-c673-14b52fe7170c@linux.intel.com>
On 24/06/19 05:10, Jing Liu wrote:
>> What do you think about @index in current function? Does it mean, we
>> need put cpuid from index to max subleaf to @entry[i]? If so, the logic
>> seems as follows,
>>
>> if (index == 0) {
>> // Put subleaf 0 into @entry
>> // Put subleaf 1 into @entry[1]
>> } else if (index < entry->eax) {
>> // Put subleaf 1 into @entry
>> } else {
>> // Put all zero into @entry
>> }
>>
>> But this seems not identical with other cases, for current caller
>> function. Or we can simply ignore @index in 0x07 and just put all
>> possible subleaf info back?
There are indeed quite some cleanups to be made there. Let me post a
series as soon as possible, and you can base your work on it.
Paolo
next prev parent reply other threads:[~2019-06-24 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 11:21 [PATCH RFC] kvm: x86: AVX512_BF16 feature support Jing Liu
2019-06-20 11:21 ` [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest Jing Liu
2019-06-20 12:16 ` Paolo Bonzini
2019-06-20 15:09 ` Liu, Jing2
2019-06-24 3:10 ` Jing Liu
2019-06-24 8:33 ` Paolo Bonzini [this message]
2019-06-24 12:06 ` Jing Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d304ae7-73c0-d2a9-cd3e-975941a91266@redhat.com \
--to=pbonzini@redhat.com \
--cc=jing2.liu@intel.com \
--cc=jing2.liu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox