From: Like Xu <like.xu.linux@gmail.com>
To: Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Like Xu <likexu@tencent.com>
Subject: Re: [PATCH v2 2/6] KVM: x86/pmu: Refactoring find_arch_event() to pmc_perf_hw_id()
Date: Wed, 9 Feb 2022 17:00:16 +0800 [thread overview]
Message-ID: <7de112b2-e6d1-1f9d-a040-1c4cfee40b22@gmail.com> (raw)
In-Reply-To: <CALMp9eQG7eqq+u3igApsRDV=tt0LdjZzmD_dC8zw=gt=f5NjSA@mail.gmail.com>
On 5/2/2022 9:55 am, Jim Mattson wrote:
>> +static unsigned int amd_pmc_perf_hw_id(struct kvm_pmc *pmc)
>> {
>> + u8 event_select = pmc->eventsel & ARCH_PERFMON_EVENTSEL_EVENT;
> On AMD, the event select is 12 bits.
Out of your carefulness, we already know this fact.
This function to get the perf_hw_id by the last 16 bits still works because we
currently
do not have a 12-bits-select event defined in the amd_event_mapping[]. The
12-bits-select
events (if any) will be programed in the type of PERF_TYPE_RAW.
IMO, a minor patch that renames some AMD variables and updates the relevant comments
to avoid misunderstandings is quite acceptable.
Thanks,
Like Xu
next prev parent reply other threads:[~2022-02-09 9:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 7:42 [PATCH v2 0/6] KVM: x86/pmu: Count two basic events for emulated instructions Like Xu
2021-11-30 7:42 ` [PATCH v2 1/6] KVM: x86/pmu: Setup pmc->eventsel for fixed PMCs Like Xu
2021-12-06 19:57 ` Jim Mattson
2021-12-09 18:49 ` Paolo Bonzini
2021-12-09 18:53 ` Jim Mattson
2021-12-09 18:57 ` Paolo Bonzini
2021-12-10 10:20 ` Like Xu
[not found] ` <CALMp9eTq8H_bJOVKwi_7j3Kum9RvW6o-G3zCLUFco1A1cvNrkQ@mail.gmail.com>
2021-12-07 6:07 ` Like Xu
2021-12-07 17:42 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 2/6] KVM: x86/pmu: Refactoring find_arch_event() to pmc_perf_hw_id() Like Xu
2021-12-09 3:52 ` Jim Mattson
2021-12-09 8:11 ` Like Xu
2021-12-09 19:24 ` Paolo Bonzini
2022-02-05 1:55 ` Jim Mattson
2022-02-09 9:00 ` Like Xu [this message]
2022-02-09 19:30 ` Jim Mattson
2022-02-10 11:28 ` Like Xu
2022-02-11 9:56 ` Ravi Bangoria
2022-02-11 18:16 ` Jim Mattson
2022-02-14 10:14 ` Ravi Bangoria
2022-02-16 7:44 ` Like Xu
2022-02-16 11:24 ` Ravi Bangoria
2021-11-30 7:42 ` [PATCH v2 3/6] KVM: x86/pmu: Reuse pmc_perf_hw_id() and drop find_fixed_event() Like Xu
2021-12-09 3:58 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 4/6] KVM: x86/pmu: Add pmc->intr to refactor kvm_perf_overflow{_intr}() Like Xu
2021-12-09 4:25 ` Jim Mattson
2021-12-09 8:28 ` Like Xu
2021-12-10 0:54 ` Jim Mattson
2021-12-10 9:35 ` Paolo Bonzini
2021-12-10 10:11 ` Like Xu
2021-12-10 22:55 ` Jim Mattson
2021-12-10 22:59 ` Paolo Bonzini
2021-12-10 23:31 ` Jim Mattson
2021-12-12 4:56 ` Jim Mattson
2021-12-13 6:37 ` Jim Mattson
2021-12-16 9:57 ` Like Xu
2021-12-16 17:52 ` Jim Mattson
2021-11-30 7:42 ` [PATCH v2 5/6] KVM: x86: Update vPMCs when retiring instructions Like Xu
2021-12-09 4:33 ` Jim Mattson
2021-12-09 8:44 ` Like Xu
2021-12-09 9:23 ` Like Xu
2021-11-30 7:42 ` [PATCH v2 6/6] KVM: x86: Update vPMCs when retiring branch instructions Like Xu
2021-12-09 4:40 ` Jim Mattson
2021-12-09 19:30 ` [PATCH v2 0/6] KVM: x86/pmu: Count two basic events for emulated instructions Paolo Bonzini
2021-12-16 10:14 ` Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de112b2-e6d1-1f9d-a040-1c4cfee40b22@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox