From: Paolo Bonzini <pbonzini@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: "Vitaly Kuznetsov" <vkuznets@redhat.com>,
"kvm list" <kvm@vger.kernel.org>, "X86 ML" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread
Date: Mon, 12 Mar 2018 18:11:32 +0100 [thread overview]
Message-ID: <7de8802b-e463-ef3b-79b2-024696e8aca1@redhat.com> (raw)
In-Reply-To: <CALCETrWmAhHijX9O1HzD0Jp=Rgawrx9jiYQh5MrXHfA0=15iuw@mail.gmail.com>
On 12/03/2018 18:00, Andy Lutomirski wrote:
>> Why in save_..._legacy? If it is about FSGSBASE, shouldn't it be in
>> save_fsgs? (Or if not I'm missing what the comment should be about).
> It could be in save_fsgs(), I guess. The main point is to make it
> clear to readers of the code in save_fsgs(), the legacy helpers, etc
> that there's another piece of code in KVM that makes the same set of
> somewhat problematic assumptions and that will need updating for
> FSGSBASE.
Okay, that's a good idea.
Paolo
next prev parent reply other threads:[~2018-03-12 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 14:02 [PATCH 0/3] x86/kvm: avoid expensive rdmsrs for FS/GS base MSRs Vitaly Kuznetsov
2018-03-12 14:02 ` [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread Vitaly Kuznetsov
2018-03-12 15:34 ` Andy Lutomirski
2018-03-12 15:55 ` Vitaly Kuznetsov
2018-03-12 16:03 ` Paolo Bonzini
2018-03-12 16:13 ` Andy Lutomirski
2018-03-12 16:18 ` Paolo Bonzini
2018-03-12 17:00 ` Andy Lutomirski
2018-03-12 17:11 ` Paolo Bonzini [this message]
2018-03-13 13:20 ` Vitaly Kuznetsov
2018-03-13 13:24 ` Paolo Bonzini
2018-03-12 14:02 ` [PATCH 2/3] x86/kvm/vmx: read MSR_KERNEL_GS_BASE " Vitaly Kuznetsov
2018-03-12 14:03 ` [PATCH 3/3] x86/kvm/vmx: avoid expensive rdmsr for MSR_GS_BASE Vitaly Kuznetsov
2018-03-12 15:42 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de8802b-e463-ef3b-79b2-024696e8aca1@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox