From: Paolo Bonzini <pbonzini@redhat.com>
To: "Jan Kiszka" <jan.kiszka@siemens.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: Unify traced vector format
Date: Mon, 23 May 2016 14:26:51 +0200 [thread overview]
Message-ID: <80e89f04-73d2-db95-8359-40c8d539a67f@redhat.com> (raw)
In-Reply-To: <5742A695.2090707@siemens.com>
On 23/05/2016 08:43, Jan Kiszka wrote:
> Specifically the change from hex to decimal helps correlating events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> include/trace/events/kvm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 526fb3d..f28292d 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq,
> __entry->coalesced = coalesced;
> ),
>
> - TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s",
> + TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s",
> __entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e,
> __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
> (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj,
> __entry->e = e;
> ),
>
> - TP_printk("dst %x vec=%u (%s|%s|%s%s)",
> + TP_printk("dst %x vec %u (%s|%s|%s%s)",
> (u8)(__entry->e >> 56), (u8)__entry->e,
> __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
> (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq,
> __entry->data = data;
> ),
>
> - TP_printk("dst %u vec %x (%s|%s|%s%s)",
> + TP_printk("dst %u vec %u (%s|%s|%s%s)",
> (u8)(__entry->address >> 12), (u8)__entry->data,
> __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
> (__entry->address & (1<<2)) ? "logical" : "physical",
>
Looks good, thanks.
Paolo
prev parent reply other threads:[~2016-05-23 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 6:43 [PATCH] KVM: Unify traced vector format Jan Kiszka
2016-05-23 12:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e89f04-73d2-db95-8359-40c8d539a67f@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox