From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D4BC433F5 for ; Mon, 11 Apr 2022 11:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242019AbiDKLsn (ORCPT ); Mon, 11 Apr 2022 07:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232089AbiDKLsm (ORCPT ); Mon, 11 Apr 2022 07:48:42 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4BAF45ACB; Mon, 11 Apr 2022 04:46:28 -0700 (PDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23BBPIMu005481; Mon, 11 Apr 2022 11:46:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=jq4d7jD2KLlnpHFOtwi+0d8kKQoNrM0Cjh4RTqOmoBk=; b=Bu1RgMXrEyzRHIO+0UIgFZ0mc4OsYpGtyvRhCLUVbX7y+szIWWzbvn65Gxx87OE2Fjq9 k7GlD+FjblOKL5gr1n40321q951cl2eULV0xBldd25uQrrnWa3qRm1l/VlhYksjvF7pm hPgMZ8KhlqrUw8BBIWKwP69+nMfmFBFNy8dcMhC+I5zGCeLAz5szRyI9CK7e2/3kk37M j4AqCSnVsIzOemIeSqgJinFx/m09jLoYW7Sz8XaBbtxycywo7yCKn88xBJhJwm1ZUuTy lgTkYYZfBHvt1MFNaqtRL7wvgwKp198lOuc5vfqUlEibn1UrInpmpKDTLi7xJHWqXkdl xw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fcgseuq6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Apr 2022 11:46:28 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 23BBVHEJ021658; Mon, 11 Apr 2022 11:46:28 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fcgseuq5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Apr 2022 11:46:27 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23BBhtDN031337; Mon, 11 Apr 2022 11:46:25 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma04fra.de.ibm.com with ESMTP id 3fb1s8td8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Apr 2022 11:46:25 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23BBkMP845613372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Apr 2022 11:46:22 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38A6BAE045; Mon, 11 Apr 2022 11:46:22 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0356AE057; Mon, 11 Apr 2022 11:46:21 +0000 (GMT) Received: from li-ca45c2cc-336f-11b2-a85c-c6e71de567f1.ibm.com (unknown [9.171.68.171]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 11 Apr 2022 11:46:21 +0000 (GMT) Message-ID: <814e7115c178c3dc6613c3935a7c81a29d72c19a.camel@linux.ibm.com> Subject: Re: [kvm-unit-tests PATCH v2 1/9] lib: s390x: hardware: Add host_is_qemu() function From: Nico Boehr To: Janosch Frank , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com Date: Mon, 11 Apr 2022 13:46:21 +0200 In-Reply-To: <20220407084421.2811-2-frankja@linux.ibm.com> References: <20220407084421.2811-1-frankja@linux.ibm.com> <20220407084421.2811-2-frankja@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: YHdFgTuRoCIPS62w4VX9vcfY7OyZaAMr X-Proofpoint-GUID: CPMIiL_3o5co6S38AEN9Mt48CgGUdRu7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-11_04,2022-04-11_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204110065 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 2022-04-07 at 08:44 +0000, Janosch Frank wrote: > In the future we'll likely need to check if we're hosted on QEMU so > let's make this as easy as possible by providing a dedicated > function. > > Signed-off-by: Janosch Frank Reviewed-by: Nico Boehr We could also adjust the check we already have in s390x/epsw.c to use the new function, but also fine to leave as-is.