From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM Date: Sun, 13 Apr 2014 15:48:36 -0700 Message-ID: <820480d8-b02f-4989-be5f-b9b5f86d5cba@email.android.com> References: <1396345596-25682-1-git-send-email-feng.wu@intel.com> <533D904E.30801@redhat.com> <533E5EE3.4030708@redhat.com> <53445E30.6010809@redhat.com> <20140410200149.GA26092@amt.cnet> <534885DC.6040603@redhat.com> <20140413215737.GA8674@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: "Wu, Feng" , "gleb@redhat.com" , "kvm@vger.kernel.org" To: Marcelo Tosatti , Paolo Bonzini Return-path: Received: from terminus.zytor.com ([198.137.202.10]:38912 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbaDMWsv (ORCPT ); Sun, 13 Apr 2014 18:48:51 -0400 In-Reply-To: <20140413215737.GA8674@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: I would like to see this in 3.15. -hpa On April 13, 2014 2:57:38 PM PDT, Marcelo Tosatti wrote: >On Fri, Apr 11, 2014 at 08:16:28PM -0400, Paolo Bonzini wrote: >> Il 10/04/2014 16:01, Marcelo Tosatti ha scritto: >> >On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: >> >>Il 07/04/2014 21:06, Wu, Feng ha scritto: >> >>>>>Even though the tests do not cover the CPL=3/implicit access >case, the >> >>>>>logic to compute PFERR_RSVD_MASK dynamically is already covered >by AC=1. >> >>>>> So I'm quite happy with the coverage. Series is >> >>>>> >> >>>>>Reviewed-by: Paolo Bonzini ] >> >>>Thanks very much for your review on this. >> >>>BTW: Since 3.15 merge window is still open, I am wondering whether >there is >> >>>any possibility to make SMAP into 3.15 with another pull request. >> >>> >> >> >> >>This is up to Marcelo who is currently managing the KVM tree. >> >> >> >>Paolo >> > >> >The merge window is for patches which have been tested in queue/next >> >for sometime. This patch has received no testing other than the >> >developer testing. >> >> This is not going to change unfortunately since this is not shipping >> in any real silicon. The only hope could be to use QEMU's SVM and >> SMAP emulation. > >Well, let me know if you want an exception to the rule so i should >merge this patchset and submit it for 3.15. > >> >> >Lack of implicit supervisor mode by instructions such as "Examples >of >> >such implicit..." in section 9.3.2, in KVM's emulator, makes the >feature >> >incomplete, does it not ? >> >> Implicit supervisor mode is handled by KVM emulator using >> read/write_std. These accesses do not set PFERR_USER_MASK, and >> should work fine with SMAP. Am I misunderstanding? >> >> Paolo > >Right. -- Sent from my mobile phone. Please pardon brevity and lack of formatting.