From: Wei Huang <whuang2@amd.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Wei Huang <wei.huang2@amd.com>,
kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vkuznets@redhat.com,
seanjc@google.com, joro@8bytes.org, bp@alien8.de,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
jmattson@google.com, wanpengli@tencent.com, bsd@redhat.com,
dgilbert@redhat.com, luto@amacapital.net
Subject: Re: [PATCH v2 1/4] KVM: x86: Factor out x86 instruction emulation with decoding
Date: Thu, 21 Jan 2021 09:31:46 -0600 [thread overview]
Message-ID: <83e320bd-9c88-b384-e72b-ce8d31c1deef@amd.com> (raw)
In-Reply-To: <3044193d-1610-fd67-e4ec-12a87fed62f2@redhat.com>
On 1/21/21 8:23 AM, Paolo Bonzini wrote:
> On 21/01/21 15:04, Maxim Levitsky wrote:
>>> +int x86_emulate_decoded_instruction(struct kvm_vcpu *vcpu, int
>>> emulation_type,
>>> + void *insn, int insn_len)
>> Isn't the name of this function wrong? This function decodes the
>> instruction.
>> So I would expect something like x86_decode_instruction.
>>
>
> Yes, that or x86_decode_emulated_instruction.
I was debating about it while making the change. I will update it to new
name in v3.
>
> Paolo
>
next prev parent reply other threads:[~2021-01-21 15:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:55 [PATCH v2 0/4] Handle #GP for SVM execution instructions Wei Huang
2021-01-21 6:55 ` [PATCH v2 1/4] KVM: x86: Factor out x86 instruction emulation with decoding Wei Huang
2021-01-21 14:04 ` Maxim Levitsky
2021-01-21 14:23 ` Paolo Bonzini
2021-01-21 15:31 ` Wei Huang [this message]
2021-01-21 6:55 ` [PATCH v2 2/4] KVM: SVM: Add emulation support for #GP triggered by SVM instructions Wei Huang
2021-01-21 14:07 ` Maxim Levitsky
2021-01-21 16:06 ` Wei Huang
2021-01-21 16:55 ` Maxim Levitsky
2021-01-21 22:40 ` Sean Christopherson
2021-01-25 13:22 ` Maxim Levitsky
2021-01-21 6:55 ` [PATCH v2 3/4] KVM: SVM: Add support for VMCB address check change Wei Huang
2021-01-21 14:08 ` Maxim Levitsky
2021-01-21 6:55 ` [PATCH v2 4/4] KVM: SVM: Support #GP handling for the case of nested on nested Wei Huang
2021-01-21 14:09 ` Maxim Levitsky
2021-01-21 14:25 ` Paolo Bonzini
2021-01-21 14:56 ` Dr. David Alan Gilbert
2021-01-21 15:10 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83e320bd-9c88-b384-e72b-ce8d31c1deef@amd.com \
--to=whuang2@amd.com \
--cc=bp@alien8.de \
--cc=bsd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox