From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3CE61B0435 for ; Wed, 29 Jan 2025 10:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738147460; cv=none; b=Krvg2eImUvXsa1efEOnIvQJhkGL9lgkZeMH4sAhimKSRWciKM14Ri0txAj7a4zIwITfwzuYyKpBUSqhC15wOtGf/AV7QrGb5mb9zt3XFRipuLjKd74DseXhcjckdqVD7SIQgur9eE7Nvx73AhcoFwHNZiF4wiZ6UU7DGVNTkEHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738147460; c=relaxed/simple; bh=nv4VuGjSok28KFpMvnhhes+J9LZ2fUvq+BQK0GUr/X4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nPfoJLpNVRMgLPqtdHWuYLVxDoAGY3lvcvJrc4VFa8YAGRnC6F+07+Zdgrszia3CgMiD1qqk/XnrZ7ffVAm6t5oSOIbIB08rpqxdU4AEXOLiOE7V1a1XBh5HCIJFV2o3cpUJTGPwnCGjzqx80lOD1h5TkivbglfHvqqlOmisqtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DT1Mli4v; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DT1Mli4v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738147457; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yWrkOMQp0EgA1n2/2fll/3eIYbXZEI0l3kIseupr1do=; b=DT1Mli4vvSphGLWtdulCl2AC1Y2EEPXg1HhiJ3fQ6E0ygcsOwMIGIlJtY5+NWbrR/hv/Yo fSBrhiTvGLmKAwFHBSagp3vN1l1Ugpl4bQj2iwhel7ySuNJv4dNH2RknBITZmgG54GrqWi er+IjrCLRAEOxHUhyEMAkwxCCPy5IP4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-4Ty4AQ67Mmet3VL15mjykw-1; Wed, 29 Jan 2025 05:44:16 -0500 X-MC-Unique: 4Ty4AQ67Mmet3VL15mjykw-1 X-Mimecast-MFC-AGG-ID: 4Ty4AQ67Mmet3VL15mjykw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4362b9c1641so31395315e9.3 for ; Wed, 29 Jan 2025 02:44:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738147455; x=1738752255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yWrkOMQp0EgA1n2/2fll/3eIYbXZEI0l3kIseupr1do=; b=mE+Nesh9unhzlZOcZ07a1kj9l4QGIq8OlnRUMlyBRnZCTDFg7PulLBYT/SelMWBDrh Ifh6awjLYud6SxO6KS+JPtCPr0UK4yn4HRL3d6m4wV0gwoRE9sytnIl06rahpR2hiPcN RkHJjySKRgzFH56vizGnHWjQc86xZAmG58/axH93HxvXWnouyfRnUjdWFaCVrfBuAj7R Sh+NCZoIfcn87b/8iPeap85MIzBdtlzz+iLjAJHSRIiEZzXjoEbCqriz+Q8onKQ2ivJf XR4Ij2V42pxNYe9Y+OxYH6DyTpM+vDnYyfm9bYB8ECVj0js79XK1CLUa9eRmFKc16WC0 f66Q== X-Forwarded-Encrypted: i=1; AJvYcCUSY2QsIzNfESNh6ByiwC2NiyU6RKDkGil67tb78LRlou5jfDt68f/2DWXw62nWV6XkZdI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+GUSQ8KmOHKX2eQojYoxF/txOsARxDE+duHeKThnAeVSAsypa 8AemDWfUH5wph221j6SbB0exPdU5k4OaYp3uLbl0fzuP61GsNmr7s6fGagWDsUFu8CV/4mId+Vg 4rwujUqbjesx8ERHEg/lZeF9C2q0eBrQM7yaIVrvd0t8XzV4ImQ== X-Gm-Gg: ASbGncsddRXbOehSfirqdhprJqmdpKHDt1VC0GpCGRP1QZ8J3wGNp7MXuMNFytXTqQF PYGc7b/NhBf7u5x0uEjqanswaHGC7MOTowUxchV1EyWnUY9mYblNH4rIRqUyEQ6015Y05g+gP7u 4PRyVdrA/BoZaa5MJGW6GLRfWjcbGMoQbbn7xo9Rq6zhtLT6cX207AF6EfhqYLOLQnzDbxTkKg2 EO/doxRyJvY3OpuxBXxGQnddD/TL2Xl2xhWMzSMev9fqDNt4Ytf7W1W9DfSZKd640imOZZoLQE7 PGKgtSrrRcm+vNLhifi8xezNmzv/x4ZQq+hIWuNg21sFTEQIZRnz X-Received: by 2002:a05:600c:3d9b:b0:434:ff08:202b with SMTP id 5b1f17b1804b1-438dc3c360dmr20853635e9.12.1738147454879; Wed, 29 Jan 2025 02:44:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzPWEOLliL6813Vkt1ndANuVcfYh0Tyo6krKSjX7AbgdnEUM8NRt3/67xnxrixA9ILfXf4Jg== X-Received: by 2002:a05:600c:3d9b:b0:434:ff08:202b with SMTP id 5b1f17b1804b1-438dc3c360dmr20853365e9.12.1738147454482; Wed, 29 Jan 2025 02:44:14 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc2f73asm18251195e9.24.2025.01.29.02.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 02:44:13 -0800 (PST) Message-ID: <840e41b8-15c7-4c4f-a503-818fb4729913@redhat.com> Date: Wed, 29 Jan 2025 11:44:11 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: eric.auger@redhat.com Subject: Re: [PATCH RFCv2 02/13] genirq/msi: Rename iommu_dma_compose_msi_msg() to msi_msg_set_msi_addr() Content-Language: en-US To: Jason Gunthorpe Cc: Nicolin Chen , will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com, joro@8bytes.org, shuah@kernel.org, reinette.chatre@intel.com, yebin10@huawei.com, apatel@ventanamicro.com, shivamurthy.shastri@linutronix.de, bhelgaas@google.com, anna-maria@linutronix.de, yury.norov@gmail.com, nipun.gupta@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, jean-philippe@linaro.org, mdf@kernel.org, mshavit@google.com, shameerali.kolothum.thodi@huawei.com, smostafa@google.com, ddutile@redhat.com References: <242034456c0bfcd7ecf75cb29d8e5c99db0675d6.1736550979.git.nicolinc@nvidia.com> <20250123185002.GV5556@nvidia.com> From: Eric Auger In-Reply-To: <20250123185002.GV5556@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jason, On 1/23/25 7:50 PM, Jason Gunthorpe wrote: > On Thu, Jan 23, 2025 at 06:10:54PM +0100, Eric Auger wrote: > >>> -/** >>> - * iommu_dma_compose_msi_msg() - Apply translation to an MSI message >>> - * @desc: MSI descriptor prepared by iommu_dma_prepare_msi() >>> - * @msg: MSI message containing target physical address >>> - */ >>> -static inline void iommu_dma_compose_msi_msg(struct msi_desc *desc, >>> - struct msi_msg *msg) >>> +static inline void msi_msg_set_msi_addr(struct msi_desc *desc, >>> + struct msi_msg *msg, u64 msi_addr) >> nit: msi_msg_set_addr(ess) may be enough as the populated fields are >> address_lo/hi > Not sure I follow, you suggest to use msi_msg_set_addr() as the > function name? Seems Ok Yes my minor point was just about removing the "msi" redundancy Eric > > Jason >