public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
	kvm@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org,
	maz@kernel.org, oliver.upton@linux.dev, seanjc@google.com,
	shan.gavin@gmail.com
Subject: Re: [PATCH 1/2] KVM: selftests: Remove duplicate VM in memslot_perf_test
Date: Fri, 27 Jan 2023 11:08:39 +1100	[thread overview]
Message-ID: <844b0302-ddb4-22b4-e807-08eca9ac8dee@redhat.com> (raw)
In-Reply-To: <b5a6f902-2d43-a7d6-5840-669760b6c9d7@maciej.szmigiero.name>

Hi Maciej,

On 1/24/23 10:56 AM, Maciej S. Szmigiero wrote:
> On 18.01.2023 10:21, Gavin Shan wrote:
>> There are two VMs created in prepare_vm(), which isn't necessary.
>> To remove the second created and unnecessary VM.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
> 
> It's weird that we ended with two __vm_create_with_one_vcpu() calls,
> it looks like the second one was accidentally (re-)introduced during
> 'kvmarm-6.2' merge, so maybe?:
> Fixes: eb5618911af0 ("Merge tag 'kvmarm-6.2' of https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into HEAD")
> 
> Anyway, thanks for spotting this:
> Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> 

Thanks for your review. Right, it'd better to have the fix tag as your suggested.
I think I probably needn't respin. I guess Paolo, Marc or Oliver may help
to add the fix tag when it's merged.

Thanks,
Gavin





  reply	other threads:[~2023-01-27  0:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  9:21 [PATCH 0/2] KVM: selftests: Remove duplicate VM in memslot_perf_test Gavin Shan
2023-01-18  9:21 ` [PATCH 1/2] " Gavin Shan
2023-01-23 23:56   ` Maciej S. Szmigiero
2023-01-27  0:08     ` Gavin Shan [this message]
2023-01-18  9:21 ` [PATCH 2/2] KVM: selftests: Assign guest page size in sync area early " Gavin Shan
2023-01-23 23:57   ` Maciej S. Szmigiero
2023-02-08  2:07 ` [PATCH 0/2] KVM: selftests: Remove duplicate VM " Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=844b0302-ddb4-22b4-e807-08eca9ac8dee@redhat.com \
    --to=gshan@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=kvmarm@lists.linux.dev \
    --cc=mail@maciej.szmigiero.name \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shan.gavin@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox