From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 21/32] arm64: KVM: Build system integration
Date: Tue, 21 May 2013 12:09:47 -0400 (EDT)
Message-ID: <850310439.5245685.1369152587054.JavaMail.root@redhat.com>
References: <1368540840-26750-1-git-send-email-marc.zyngier@arm.com> <1368540840-26750-22-git-send-email-marc.zyngier@arm.com> <20130521154227.GM27002@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Marc Zyngier <Marc.Zyngier@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org, Will Deacon <Will.Deacon@arm.com>,
	gleb@redhat.com, Christopher Covington <cov@codeaurora.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3-phx2.redhat.com ([209.132.183.24]:41291 "EHLO
	mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754691Ab3EUQK1 convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 21 May 2013 12:10:27 -0400
In-Reply-To: <20130521154227.GM27002@arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



----- Messaggio originale -----
> Da: "Catalin Marinas" <catalin.marinas@arm.com>
> A: "Marc Zyngier" <Marc.Zyngier@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.ed=
u, kvm@vger.kernel.org, "Will Deacon"
> <Will.Deacon@arm.com>, pbonzini@redhat.com, gleb@redhat.com, "Christo=
pher Covington" <cov@codeaurora.org>
> Inviato: Marted=C3=AC, 21 maggio 2013 17:42:27
> Oggetto: Re: [PATCH v4 21/32] arm64: KVM: Build system integration
>=20
> On Tue, May 14, 2013 at 03:13:49PM +0100, Marc Zyngier wrote:
> > --- /dev/null
> > +++ b/arch/arm64/kvm/Kconfig
> ...
> > +config KVM_ARM_VGIC
> > +        bool
> > +	depends on KVM_ARM_HOST && OF
> > +	select HAVE_KVM_IRQCHIP
> > +	---help---
> > +	  Adds support for a hardware assisted, in-kernel GIC emulation.
> > +
> > +config KVM_ARM_TIMER
> > +        bool
> > +	depends on KVM_ARM_VGIC
> > +	select HAVE_KVM_IRQCHIP
> > +	---help---
> > +	  Adds support for the Architected Timers in virtual machines
> > +
> > +source drivers/virtio/Kconfig
>=20
> Shouldn't the above configs go to drivers/virtio/Kconfig as well (or
> drivers/virtio/arm/Kconfig)?

virtio doesn't mean "virtual versions of devices that also exist in
hardware"; those are indeed in arch/ARCH/kvm.  virtio is a specific bus
for paravirtualized devices.  It is not KVM-specific and the code runs
in the guest (whereas arch/arm64/kvm/Kconfig is host code).

That said, drivers/virtio/Kconfig is already sourced by drivers/Kconfig=
=2E
Why do you need to source it again here?

Paolo