From mboxrd@z Thu Jan  1 00:00:00 1970
From: Auger Eric <eric.auger@redhat.com>
Subject: Re: [PATCH v7 09/17] KVM: arm64: introduce ITS emulation file with
 MMIO framework
Date: Mon, 4 Jul 2016 15:54:17 +0200
Message-ID: <8546ac45-f7cd-31af-a261-bb85ca7305ca@redhat.com>
References: <20160628123230.26255-1-andre.przywara@arm.com>
 <20160628123230.26255-10-andre.przywara@arm.com>
 <3fec9632-ce39-3508-2b71-4049fc959a64@redhat.com>
 <32d54016-731d-e4a9-272d-8b0934ebec31@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
To: Andre Przywara <andre.przywara@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35428 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753564AbcGDNyU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 Jul 2016 09:54:20 -0400
In-Reply-To: <32d54016-731d-e4a9-272d-8b0934ebec31@arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Andre,

On 04/07/2016 15:38, Andre Przywara wrote:
> 2) on KVM_DEV_ARM_VGIC_GRP_ADDR check that "initialized" is false
> 3) on KVM_DEV_ARM_VGIC_CTRL_INIT check that "initialized" is false
> 4) after KVM_DEV_ARM_VGIC_CTRL_INIT set initialized to true
> 
> I don't want to rely solely on vgic_its_base being ADDR_UNDEF, since I
> expect we extend that interface later by supporting more options (for
> instance to size the virtual ITS, in terms of devices, number of LPIs,
> collections, etc.)
> 
> Does that make sense?
> Or do we need more here?

So you will accept a call to KVM_DEV_ARM_VGIC_CTRL_INIT with an unset
address? I don't think this is relevant.

Thanks

Eric