Re: [PATCH v3 2/5] crypto: ccp: Add missing member in SNP_LAUNCH_START command structure

[Nikunj A Dadhania <nikunj@amd.com>]

Tom Lendacky <thomas.lendacky@amd.com> writes:

> On 2/17/25 04:22, Nikunj A Dadhania wrote:
>> The sev_data_snp_launch_start structure should include a 4-byte
>> desired_tsc_khz field before the gosvw field, which was missed in the
>> initial implementation. As a result, the structure is 4 bytes shorter than
>> expected by the firmware, causing the gosvw field to start 4 bytes early.
>> Fix this by adding the missing 4-byte member for the desired TSC frequency.
>> 
>> Fixes: 3a45dc2b419e ("crypto: ccp: Define the SEV-SNP commands")
>> Cc: stable@vger.kernel.org
>> Suggested-by: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> Even though you're using the "crypto: ccp:" tag (which should actually
> be "crypto: ccp -"), this can probably go through the KVM tree. Not sure
> if it makes sense to tag it as "KVM: SVM:" instead.

Thanks, I will update the subject.

Regards
Nikunj