From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5017C1C29F; Wed, 29 Nov 2023 13:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kccmNgq6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF7EC433C7; Wed, 29 Nov 2023 13:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701263173; bh=Zp61shLyUnmkhFl9ObPSjYNpDDNPYQkP0AH3PadNsgo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kccmNgq6Oc9NJCFKbkP2kKJzvNM4gfzZLrHszvHbAHqzL2pl/bptYB0i/M+fs/Crn zI7jJ6tmVsYXvR1p9Fwi1v8ZCvwAfI95U4dcScuKLhlkwJMhM0WarG5PvivgBsswy/ LN6m7cPJJ5FOrdAQUhpm5CNLe8WHttpjCm/qlMM3KMqonhjEKWcMXGH6lU5ZjO9Ifr eiLwdnjBpal8JZBNzFKPJOSon3po1her9v427H9nThluEhpcYiRo6Fo81u9YudvVRa XtzbDHYF6uu7VAmMkDVDnRE7/uqBS4wiNyFkarK4zASwikKMEbxXewUako8fssLBvP u57yOzYnsViEQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r8KGZ-00HWEG-H0; Wed, 29 Nov 2023 13:06:11 +0000 Date: Wed, 29 Nov 2023 13:06:11 +0000 Message-ID: <864jh4d7zw.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v2 3/3] arm64: Rename reserved values for CTR_EL0.L1Ip In-Reply-To: References: <20231127172613.1490283-1-maz@kernel.org> <20231127172613.1490283-4-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, ardb@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 Nov 2023 07:13:57 +0000, Anshuman Khandual wrote: > > > > On 11/27/23 22:56, Marc Zyngier wrote: > > We now have *two* values for CTR_EL0.L1Ip that are reserved. > > Which makes things a bit awkward. In order to lift the ambiguity, > > rename RESERVED (0b01) to RESERVED_AIVIVT, and VPIPT (0b00) to > > RESERVED_VPIPT. > > > > This makes it clear which of these meant what, and I'm sure > > archeologists will find it useful... > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/tools/sysreg | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > > index 96cbeeab4eec..5a217e0fce45 100644 > > --- a/arch/arm64/tools/sysreg > > +++ b/arch/arm64/tools/sysreg > > @@ -2004,9 +2004,10 @@ Field 27:24 CWG > > Field 23:20 ERG > > Field 19:16 DminLine > > Enum 15:14 L1Ip > > - 0b00 VPIPT > > + # This was named as VPIPT in the ARM but now documented as reserved > > + 0b00 RESERVED_VPIPT > > # This is named as AIVIVT in the ARM but documented as reserved > > - 0b01 RESERVED > > + 0b01 RESERVED_AVIVT > > s/RESERVED_AVIVT/RESERVED_AIVIVT - matches the spec. Commit message > has got this right. Huh, how embarrassing. Thanks for pointing this out, I'll fix it in the next round. M. -- Without deviation from the norm, progress is not possible.