From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965E8305968; Mon, 10 Nov 2025 13:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762780269; cv=none; b=RXHQN0PlzOID1z39JI3B8ivbcNGJMWFd+XsaZfR/ZvsrK5V5vQRTf4Fny2fEeY6kNkBm0UNsOhAUw7MhtTLysER3qk52CYo8xriAhPRQGnnKRz2vrEyG6E+0JeG0QZGwpaOnX29GsbNVtKNg3jt2TCmruckt+XP6lgN9DdJXI1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762780269; c=relaxed/simple; bh=qw9MX581WnhmMom2rBbLrZv+6wBNDSv1qI3/Z5yj/+o=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=tgGQjrLjwqdOEkNdLt1lJRDF6gkfZvueIqpJpW8VJqa28pWgyap01O+/g+ZHRYLo2wn0xA+S0ASavWKsfB6Oe3vK99LmyLwuAOMckPZsRfuxu+zhKxk3Zw9yslMBjHa0fCYnSkfEV2Tj8fnt1e8H+LcbROvOSaeXYSdo5HMN3co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HA45JRSK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HA45JRSK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B286C4CEFB; Mon, 10 Nov 2025 13:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762780268; bh=qw9MX581WnhmMom2rBbLrZv+6wBNDSv1qI3/Z5yj/+o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HA45JRSKa4wThdCDie0yZqfLA4s9jpUixk6E3qNfr6PA7T/x+/8MEFdfr2lnZ68jX qK6HK62GmjvooK8R+So9EvafCE0HvNOH4FdMN1OQDWrRhMU/MJj7lzJTfogOvpoeZw gPiCe6UAjKV610ugCm0jJBxFJNsfSFeFHTjkyU+6b79i3G4UTF02Jg5arwj5o39rLs k9fDx3OnljxROzv/NVGNaNVM/Y/3uTDFhMtEVGDbFIua1EyS4KpcD1ChSqtQazJRPh XBisFHRw+2UDVEuz80lEHQ2QI5F3zDKJkPwaaM8iuNEGO8k43g04Nyx0aRPR0U/NhU qCVrGtNelWGaQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vIRfl-00000003rvi-2p3d; Mon, 10 Nov 2025 13:11:05 +0000 Date: Mon, 10 Nov 2025 13:11:05 +0000 Message-ID: <865xbiuj6e.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Peter Maydell , Paolo Bonzini , Aishwarya.TCV@arm.com Subject: Re: [PATCH v2 3/3] KVM: arm64: Limit clearing of ID_{AA64PFR0,PFR1}_EL1.GIC to userspace irqchip In-Reply-To: References: <20251030122707.2033690-1-maz@kernel.org> <20251030122707.2033690-4-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, peter.maydell@linaro.org, pbonzini@redhat.com, Aishwarya.TCV@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 10 Nov 2025 12:51:55 +0000, Mark Brown wrote: > > On Thu, Oct 30, 2025 at 12:27:07PM +0000, Marc Zyngier wrote: > > Now that the idreg's GIC field is in sync with the irqchip, limit > > the runtime clearing of these fields to the pathological case where > > we do not have an in-kernel GIC. > > > > While we're at it, use the existing API instead of open-coded > > accessors to access the ID regs. > > Today's next/pending-fixes is showing regressions on a range of physical > arm64 platforms (including at least a bunch of A53 systems, an A55 one > and an A72 one) in the steal_time selftest which bisect to this patch. > We get asserts in the kernel on ID register sets: > > [ 150.872407] WARNING: CPU: 0 PID: 2865 at arch/arm64/kvm/sys_regs.c:2353 kvm_set_vm_id_reg+0x9c/0xf4 > > ... > > [ 151.045312] Call trace: > [ 151.047780] kvm_set_vm_id_reg+0x9c/0xf4 (P) > [ 151.052098] kvm_finalize_sys_regs+0x88/0x240 > [ 151.056504] kvm_arch_vcpu_run_pid_change+0xb4/0x438 > [ 151.061527] kvm_vcpu_ioctl+0x92c/0x9d0 Please name the platforms this fails on. Here, on a sample of one A72 box, I don't see the issue: maz@sy-borg:~$ ./steal_time Random seed: 0x6b8b4567 TAP version 13 1..4 ok 1 vcpu0 ok 2 vcpu1 ok 3 vcpu2 ok 4 vcpu3 # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0 Thanks, M. -- Without deviation from the norm, progress is not possible.