From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BCF71BC53; Thu, 25 Jan 2024 09:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706174911; cv=none; b=UERsnRDNGAJyznILhyJG7ovy1h4Ce+laiEmIbC30o3/zjNImW8JsN+no2Upp/bAqTOEGA6UafkD9ySzkopBZNO0Sj1mZlEMTZWLP+fZ0wmHJpJaOWVD/8ptgsk9S1c8HzGk+JFu4cKtePby9tF0XaHk6TvnpIKhUFSDHNJr3LlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706174911; c=relaxed/simple; bh=pKhdW4ryOlNMj6WnoDncrg0CpAv7nCulY96ruTKsQS0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=YlkoNbbaaAW/0eKunQf/cDvZJhCix03UZv9ehgnCfgjWt+pWS+w3Gz9oxhcU08TOoVBug3EB/ztbEbdQswqL8kXgCN1I2np5cyftJq6NfMECFB/RH/t1f420wvLedDCsrc+xmguIjvK44eIr7Bq23VO8xOw+brFVMNnbl2pF8cI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hE33YvnI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hE33YvnI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EA34C433C7; Thu, 25 Jan 2024 09:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706174910; bh=pKhdW4ryOlNMj6WnoDncrg0CpAv7nCulY96ruTKsQS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hE33YvnI2Y3jEJsSZNAkARstlPiMISPmjSsoRft/o10TZmxEhFY+bVHk3LMYRNRxB 6II8e8Lg27dlOcOZxSe0ebwdHOLh6Q3QcYxAYg3M8pszDSTm9HkmsWzMism0IWYxGe eTYaI3cHT4XUOKcXjdYvFaTWWI6DKS2gDLvwHRrFCc2pzOCAhcuE9Z14nmnnHHxZSq JppEsrwgtyj4h6RGiRL33PWZVTSaozNvAHRLgTmjZ9NJx6x54/TSIrWfDH5nNR3tfG +xzL8Qn488i8yR8QuDh8nVNDVheApAeCwIVus6V7jYd9zoI++v2uz4ir+g29KF52xh eSB75637n6T8g== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rSw28-00EfOY-D9; Thu, 25 Jan 2024 09:28:28 +0000 Date: Thu, 25 Jan 2024 09:28:27 +0000 Message-ID: <865xzh92ys.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Raghavendra Rao Ananta , Jing Zhang Subject: Re: [PATCH 05/15] KVM: arm64: vgic: Get rid of the LPI linked-list In-Reply-To: <20240124204909.105952-6-oliver.upton@linux.dev> References: <20240124204909.105952-1-oliver.upton@linux.dev> <20240124204909.105952-6-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, rananta@google.com, jingzhangos@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 24 Jan 2024 20:48:59 +0000, Oliver Upton wrote: > > All readers of LPI configuration have been transitioned to use the LPI > xarray. Get rid of the linked-list altogether. > > Signed-off-by: Oliver Upton > --- > arch/arm64/kvm/vgic/vgic-init.c | 1 - > arch/arm64/kvm/vgic/vgic-its.c | 7 ++----- > arch/arm64/kvm/vgic/vgic.c | 1 - > include/kvm/arm_vgic.h | 1 - > 4 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c > index 411719053107..e25672d6e846 100644 > --- a/arch/arm64/kvm/vgic/vgic-init.c > +++ b/arch/arm64/kvm/vgic/vgic-init.c > @@ -53,7 +53,6 @@ void kvm_vgic_early_init(struct kvm *kvm) > { > struct vgic_dist *dist = &kvm->arch.vgic; > > - INIT_LIST_HEAD(&dist->lpi_list_head); > INIT_LIST_HEAD(&dist->lpi_translation_cache); > raw_spin_lock_init(&dist->lpi_list_lock); > xa_init_flags(&dist->lpi_xa, XA_FLAGS_LOCK_IRQ); > diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c > index a2d95a279798..0486d3779d11 100644 > --- a/arch/arm64/kvm/vgic/vgic-its.c > +++ b/arch/arm64/kvm/vgic/vgic-its.c > @@ -74,10 +74,8 @@ static struct vgic_irq *vgic_add_lpi(struct kvm *kvm, u32 intid, > * There could be a race with another vgic_add_lpi(), so we need to > * check that we don't add a second list entry with the same LPI. > */ > - list_for_each_entry(oldirq, &dist->lpi_list_head, lpi_list) { > - if (oldirq->intid != intid) > - continue; > - > + oldirq = xa_load(&dist->lpi_xa, intid); > + if (oldirq) { > /* Someone was faster with adding this LPI, lets use that. */ > kfree(irq); > irq = oldirq; > @@ -99,7 +97,6 @@ static struct vgic_irq *vgic_add_lpi(struct kvm *kvm, u32 intid, > return ERR_PTR(ret); > } > > - list_add_tail(&irq->lpi_list, &dist->lpi_list_head); > dist->lpi_list_count++; > > out_unlock: > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > index d90c42ff051d..e58ce68e325c 100644 > --- a/arch/arm64/kvm/vgic/vgic.c > +++ b/arch/arm64/kvm/vgic/vgic.c > @@ -121,7 +121,6 @@ void __vgic_put_lpi_locked(struct kvm *kvm, struct vgic_irq *irq) > if (!kref_put(&irq->refcount, vgic_irq_release)) > return; > > - list_del(&irq->lpi_list); > xa_erase(&dist->lpi_xa, irq->intid); > dist->lpi_list_count--; > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index 795b35656b54..39037db3fa90 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -277,7 +277,6 @@ struct vgic_dist { > /* Protects the lpi_list and the count value below. */ > raw_spinlock_t lpi_list_lock; > struct xarray lpi_xa; > - struct list_head lpi_list_head; > int lpi_list_count; > > /* LPI translation cache */ You seem to be missing some of it (patch against the full series, so context will be wrong): diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c index 46ff21fea785..3de41ee5e6ee 100644 --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -58,7 +58,6 @@ static struct vgic_irq *vgic_add_lpi(struct kvm *kvm, u32 intid, return ERR_PTR(ret); } - INIT_LIST_HEAD(&irq->lpi_list); INIT_LIST_HEAD(&irq->ap_list); raw_spin_lock_init(&irq->irq_lock); diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h index f3fc2cc922ce..4439039ccd45 100644 --- a/include/kvm/arm_vgic.h +++ b/include/kvm/arm_vgic.h @@ -118,7 +118,6 @@ struct irq_ops { struct vgic_irq { raw_spinlock_t irq_lock; /* Protects the content of the struct */ struct rcu_head rcu; - struct list_head lpi_list; /* Used to link all LPIs together */ struct list_head ap_list; struct kvm_vcpu *vcpu; /* SGIs and PPIs: The VCPU M. -- Without deviation from the norm, progress is not possible.