From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v2] KVM: arm64: Add tracepoint for MMIO accesses where ISV==0
Date: Fri, 27 Oct 2023 11:11:57 +0100 [thread overview]
Message-ID: <867cn84bo2.wl-maz@kernel.org> (raw)
In-Reply-To: <20231026205306.3045075-1-oliver.upton@linux.dev>
On Thu, 26 Oct 2023 21:53:06 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> It is a pretty well known fact that KVM does not support MMIO emulation
> without valid instruction syndrome information (ESR_EL2.ISV == 0). The
> current kvm_pr_unimpl() is pretty useless, as it contains zero context
> to relate the event to a vCPU.
>
> Replace it with a precise tracepoint that dumps the relevant context
> so the user can make sense of what the guest is doing.
>
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
Acked-by: Marc Zyngier <maz@kernel.org>
Thanks for going the extra mile on this!
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2023-10-27 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 20:53 [PATCH v2] KVM: arm64: Add tracepoint for MMIO accesses where ISV==0 Oliver Upton
2023-10-27 7:57 ` Zenghui Yu
2023-10-27 10:11 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cn84bo2.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox