From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513BFC4332F for ; Mon, 12 Dec 2022 09:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbiLLJFI (ORCPT ); Mon, 12 Dec 2022 04:05:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiLLJFG (ORCPT ); Mon, 12 Dec 2022 04:05:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C7942DC4 for ; Mon, 12 Dec 2022 01:05:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4BA960F39 for ; Mon, 12 Dec 2022 09:05:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CF43C433D2; Mon, 12 Dec 2022 09:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670835905; bh=ufqahpMAcB+LIb2i+yx9UJwmo67U+MbnKsRVmoX94ck=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CDh/9mWYnr0KDdCMbl1XEmwaBaKzi3JfBmKPkqqtNTDFlvA9fMLtAY55afOLiuYyZ QuBiCitVzcPpxumOuHJIZ/okisWEG2pcv/x2xJS6GabNp8y++Vt8DP2qV7PAgLZBEc TJw4xCGqZCxM5hWhi31eL6FGrQlcRbiGKzOsOe7jKo/RftxfF+/55lHFH0dJqaR3EV xUbkHGAaoxIQ5VGZsC6CaiziPKSPPtC6Q0VOOFlBu+JwSnzVn3unhec1GMMPJF4Cji qzFteM4SCzOhwL8LvrtpN3rHsKakbUcLZ82AjiaAkIHpVR/NiEGfaYYYtU7EOu6zTw R523+kjLGARJQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p4ekA-00C3Xu-Lv; Mon, 12 Dec 2022 09:05:02 +0000 Date: Mon, 12 Dec 2022 09:05:02 +0000 Message-ID: <867cyxq9fl.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: Ricardo Koller , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev, eric.auger@redhat.com, oliver.upton@linux.dev, reijiw@google.com Subject: Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters In-Reply-To: References: <20221202045527.3646838-1-ricarkol@google.com> <20221202045527.3646838-2-ricarkol@google.com> <87fsdnfroe.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, ricarkol@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev, eric.auger@redhat.com, oliver.upton@linux.dev, reijiw@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Alex, On Sun, 11 Dec 2022 11:40:39 +0000, Alexandru Elisei wrote: > > A simple "hey, you're wrong here, the PMU extensions do not follow the > principles of the ID scheme for fields in ID registers" would have > sufficed. This is what I did, and saved you the hassle of looking it up. > Guess you never made a silly mistake ever, right? It's not so much about making a silly mistake. I do that all the time. But it is about the way you state these things, and the weight that your reviews carry. You're a trusted reviewer, with a lot of experience, and posting with an @arm.com address: what you say in a public forum sticks. When you assert that the author is wrong, they will take it at face value. > Otherwise, good job encouraging people to help review KVM/arm64 patches ;) What is the worse: no review? or a review that spreads confusion? Think about it. I'm all for being nice, but I will call bullshit when I see it asserted by people with a certain level of authority. And I've long made up my mind about the state of the KVM/arm64 review process -- reviews rarely come from people who have volunteered to do so, but instead from those who have either a vested interest in it, or an ulterior motive. Hey ho... M. -- Without deviation from the norm, progress is not possible.