From: Marc Zyngier <maz@kernel.org>
To: chenxiang <chenxiang66@hisilicon.com>
Cc: <oliver.upton@linux.dev>, <james.morse@arm.com>,
<kvmarm@lists.linux.dev>, <kvm@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: Re: [PATCH] KVM: arm64: Fix the name of sys_reg_desc related to PMU
Date: Wed, 12 Jul 2023 09:36:20 +0100 [thread overview]
Message-ID: <868rblwmpn.wl-maz@kernel.org> (raw)
In-Reply-To: <1689148505-13914-1-git-send-email-chenxiang66@hisilicon.com>
On Wed, 12 Jul 2023 08:55:05 +0100,
chenxiang <chenxiang66@hisilicon.com> wrote:
>
> From: Xiang Chen <chenxiang66@hisilicon.com>
>
> For those PMU system registers defined in sys_reg_descs[], use macro
> PMU_SYS_REG() / PMU_PMEVCNTR_EL0 / PMU_PMEVTYPER_EL0 to define them, and
> later two macros call macro PMU_SYS_REG() actually.
> Currently the input parameter of PMU_SYS_REG() is other macro which is
> calculation formula of the value of system registers, so for example, if
> we want to "SYS_PMINTENSET_EL1" as the name of sys register, actually
> the name will be as following:
> (((3) << 19) | ((0) << 16) | ((9) << 12) | ((14) << 8) | ((1) << 5))
>
> To fix the issue, use the name as a input parameter of PMU_SYS_REG like
> MTE_REG or EL2_REG.
Why is the name relevant? Is this related to tracing?
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-07-12 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 7:55 [PATCH] KVM: arm64: Fix the name of sys_reg_desc related to PMU chenxiang
2023-07-12 8:36 ` Marc Zyngier [this message]
2023-07-13 2:35 ` chenxiang (M)
2023-07-13 6:56 ` Marc Zyngier
2023-07-13 9:10 ` chenxiang (M)
2023-07-13 9:40 ` Marc Zyngier
2023-07-14 3:13 ` chenxiang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868rblwmpn.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linuxarm@huawei.com \
--cc=oliver.upton@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox