From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sebastian Herbszt" Subject: Re: [Bochs-developers] [PATCH][BIOS] Fill IPL tableaccordingdiscovered ATA drives Date: Tue, 9 Dec 2008 23:50:36 +0100 Message-ID: <86DD21F097274F32B39EBA6C75AC6800@FSCPC> References: <1228494009-20270-1-git-send-email-Laurent.Vivier@bull.net> <4A58ABD7D38C471D9D5865C3E634515E@FSCPC> <1228730730.4025.2.camel@frecb07144> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed reply-type=original Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , To: "Laurent Vivier" Return-path: Received: from mail.gmx.net ([213.165.64.20]:50807 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753185AbYLIWvc (ORCPT ); Tue, 9 Dec 2008 17:51:32 -0500 In-Reply-To: <1228730730.4025.2.camel@frecb07144> Sender: kvm-owner@vger.kernel.org List-ID: Laurent Vivier wrote: > Le dimanche 07 d=C3=A9cembre 2008 =C3=A0 19:11 +0100, Sebastian Herbs= zt a =C3=A9crit : >> Laurent Vivier wrote: >> > This patch shows in boot menu only available devices. >> > >> > This patch has been tested with Bochs BIOS version from the KVM so= urce tree. >> > >> > Signed-off-by: Laurent Vivier >> > --- >> > bios/rombios.c | 54 +++++++++++++++++++++++++++++++++++++-------= ---------- >> > 1 files changed, 37 insertions(+), 17 deletions(-) >> > >> > diff --git a/bios/rombios.c b/bios/rombios.c >> > index 70b3584..d2a7c09 100644 >> > --- a/bios/rombios.c >> > +++ b/bios/rombios.c >> > @@ -1981,18 +1981,6 @@ init_boot_vectors() >> > memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e, = sizeof (e)); >> > count++; >> > >> > - /* First HDD */ >> > - e.type =3D IPL_TYPE_HARDDISK; e.flags =3D 0; e.vector =3D 0; e.= description =3D 0; e.reserved =3D 0; >> > - memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e,= sizeof (e)); >> > - count++; >> >> We need this bit for the !BX_USE_ATADRV case. Please "#if !BX_USE_AT= ADRV ... #endif" it >> instead of removing. > > If there is no ATA drive, what is the aim of adding an harddrive in t= he IPL table ? I think BX_USE_ATADRV enables the "new" ATA/ATAPI driver. You can still= use hard drives with the older code enabled by BX_USE_ATADRV=3D0. - Sebastian