From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] KVM: x86: Avoid guest page table walk when gpa_available is set Date: Thu, 27 Jul 2017 15:49:14 +0200 Message-ID: <86b4e9e3-b594-4470-375e-10a2a3e6a4ea@redhat.com> References: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, Thomas.Lendacky@amd.com To: Brijesh Singh , rkrcmar@redhat.com, joro@8bytes.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 19/05/2017 17:12, Brijesh Singh wrote: > - vcpu_is_mmio_gpa(vcpu, addr, exception->address, write) && > (addr & ~PAGE_MASK) == (exception->address & ~PAGE_MASK)) { ^^^^^^^^^^^^^^^^^^ I think this should be vcpu->arch.gpa_val. Paolo > - gpa = exception->address; > - goto mmio; > - } > + gpa = vcpu->arch.gpa_val; > + ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write); > + } else { >