From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A0173090C6; Fri, 14 Nov 2025 09:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113061; cv=none; b=nEGSFNdQH9csDK627dNPPjCJqJDYwTxX+xxtq4452+2Nlk5F+ZbcwatEGlUIfMRNgR5YzphVypAF1qnf5/2RN3w/zqjlmgGRrUmKjkLy7i+GyZQW2qeEaXatdF5or5x8c0qj50n+9KA0H8aZwxh+OZZyFf/ZgjbTuAUSzhg7wxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113061; c=relaxed/simple; bh=3N2qHHebaLsgIZzS0J6BkkzTUjzTAKRxRZhlf8ATkdM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=tSqickdApl9AG80DJ9ksqDnH78g/Gx21ZWAqeJm3a1k4EsqfMGifMYmAwQjPNeJm58JjzIHo47fzbkiXV1aqs8EfCD6pgIBzV+k2Qv0f3cK/qb1Koa04LQ8u7YIImrmvntFcu5TtyYWMyeB4UdBvTA7xnFs2XMHt1RCQI47FQew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iDw/z3R4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iDw/z3R4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DF62C2BC87; Fri, 14 Nov 2025 09:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763113060; bh=3N2qHHebaLsgIZzS0J6BkkzTUjzTAKRxRZhlf8ATkdM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iDw/z3R4erxFbJeQbSJ4uRNPlm751QKbaX9se6e/Fz+n1PfHRHkqL2VltD4nw+Gua bWSyF3IJyTNN26VB1RCQRfYuWPJiueheKVkUSHt/4Yf0GjblMVtCclIg+8zDuIfiDA 7HrtlBolMF9Glva2+hCtQcWV+JpFs9aGDdHMhBMAj4OWcv2H2XbrBKctH0ZCOcWJla jvQN3BWwV5ncQjFOK6rZm6/bPuSb0BPlq8YqpMeifSV/pU+sxQL701brSRoNPFb1O3 WLaEe2MJUZI/0x8lOg6HRhJLum+cy7kKh/4c5/4aubrkdoGAK/tyvH8Uv/46CuRItE JD+Dm3gOyINAg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vJqFN-000000059uW-3oqS; Fri, 14 Nov 2025 09:37:38 +0000 Date: Fri, 14 Nov 2025 09:37:37 +0000 Message-ID: <86ecq1t0ny.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Christoffer Dall , Volodymyr Babchuk , Yao Yuan , Sascha Bischoff , Stephen Rothwell , Aishwarya.TCV@arm.com Subject: Re: [PATCH v2 04/45] KVM: arm64: Turn vgic-v3 errata traps into a patched-in constant In-Reply-To: <72e1e8b5-e397-4dc5-9cd6-a32b6af3d739@sirena.org.uk> References: <20251109171619.1507205-1-maz@kernel.org> <20251109171619.1507205-5-maz@kernel.org> <72e1e8b5-e397-4dc5-9cd6-a32b6af3d739@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oupton@kernel.org, yuzenghui@huawei.com, christoffer.dall@arm.com, Volodymyr_Babchuk@epam.com, yaoyuan@linux.alibaba.com, Sascha.Bischoff@arm.com, sfr@canb.auug.org.au, Aishwarya.TCV@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 13 Nov 2025 18:01:57 +0000, Mark Brown wrote: > > [1 ] > On Sun, Nov 09, 2025 at 05:15:38PM +0000, Marc Zyngier wrote: > > The trap bits are currently only set to manage CPU errata. However, > > we are about to make use of them for purposes beyond beating broken > > CPUs into submission. > > > > For this purpose, turn these errata-driven bits into a patched-in > > constant that is merged with the KVM-driven value at the point of > > programming the ICH_HCR_EL2 register, rather than being directly > > stored with with the shadow value.. > > We're seeing the no-vgic-v3 failures in -next with slightly different > symptoms to those that were seen in mainline and fixed with Sacha's > change da888524c393 ("KVM: arm64: vgic-v3: Trap all if no in-kernel > irqchip"). That change generated a conflict with this patch which > Stephen resolved in what looks like a reasonable fashion tactically but > I suspect needs some wider changes. The test now fails with: > > # selftests: kvm: no-vgic-v3 > # Random seed: 0x6b8b4567 > # ==== Test Assertion Failure ==== > # lib/arm64/processor.c:487: false > # pid=2080 tid=2080 errno=4 - Interrupted system call > # 1 0x0000000000413d27: assert_on_unhandled_exception at processor.c:487 > # 2 0x0000000000406c1f: _vcpu_run at kvm_util.c:1699 > # 3 (inlined by) vcpu_run at kvm_util.c:1710 > # 4 0x000000000040308b: test_run_vcpu at no-vgic-v3.c:124 > # 5 0x0000000000402253: test_guest_no_gicv3 at no-vgic-v3.c:155 > # 6 (inlined by) main at no-vgic-v3.c:174 > # 7 0x0000ffff9dc17543: ?? ??:0 > # 8 0x0000ffff9dc17617: ?? ??:0 > # 9 0x000000000040242f: _start at ??:? > # Unexpected exception (vector:0x4, ec:0x18) > not ok 25 selftests: kvm: no-vgic-v3 # exit=254 Fix at 20251114093541.3216162-1-maz@kernel.org based on kvmarm/next. I haven't tried -next. M. -- Without deviation from the norm, progress is not possible.