From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03C2C6FD1F for ; Tue, 14 Mar 2023 18:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjCNSTQ (ORCPT ); Tue, 14 Mar 2023 14:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbjCNSTK (ORCPT ); Tue, 14 Mar 2023 14:19:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA00B6230D for ; Tue, 14 Mar 2023 11:18:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2AFB0B81AD0 for ; Tue, 14 Mar 2023 18:18:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFBFFC4339B; Tue, 14 Mar 2023 18:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678817932; bh=My0qKjylZkeXmptIjgNvTHL0FPeH1/JBYiGK3HqA+Ko=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LBrhjt/XIWz1B2ALxXNBkHMWdd+HVFNDEtyPA+f2BaFSFRqTYBmyU8cKcdAfCqe3o ZPwJMhoj5nEI4lIOpk5l2kDHyNBPCRzAz41YFTk0zEoGA9zAxbajM0mUnbML70SbsX z9ziiKEEPev+zLa1wUUF/+flhVH34ajRxeLJ/PmAEwbzs1VKudgPyNfK0o8Z2wvrWK E9M8psEg53FsIX/eVsvzSKAa2//TGt3ecb+citG3qrDW5Z8USVaxxzXwY5Rm4qZ7R6 KxbCTyVdO3jFaLH98SCYGKXcABFZTXJLJwoaaHd+aS3mJXQ2fxmUz/yvx/2KdVbrB3 I2l1bGz6f4JHw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pc9EY-0003h6-EE; Tue, 14 Mar 2023 18:18:50 +0000 Date: Tue, 14 Mar 2023 18:18:50 +0000 Message-ID: <86edprxkl1.wl-maz@kernel.org> From: Marc Zyngier To: Colton Lewis Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org Subject: Re: [PATCH 15/16] KVM: arm64: selftests: Augment existing timer test to handle variable offsets In-Reply-To: References: <86o7owyj0a.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: coltonlewis@google.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 14 Mar 2023 17:47:01 +0000, Colton Lewis wrote: > > I'll be looking at it and will keep in mind your questions about my > hardware should I find any issues. Yes it has ECV and CNTPOFF but no I > didn't try turning it off for this because my issue occured only when > setting a physical offset and that can't be done without ECV. And yet this is exactly what these patches do: allow setting a physical offset without ECV+CNTPOFF. CNTPOFF is only a performance optimisation. It could be that my handling of CNTPOFF is buggy, or that your HW is less than stellar, or both. Testing the various combinations would certainly help. M. -- Without deviation from the norm, progress is not possible.