From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7F6E1990B7; Mon, 17 Jun 2024 18:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718648230; cv=none; b=CoA+XDVnV0wURmbg5+5kyyq+jErz2f9DJ/Un6riCbJffR+BU15UZfhdKoGOzgKwGh8yFmt2ZXDp2gtlRdaUNNH5iNyMk240CqyHiKlc0migftLiWS9BiVQwoHFOaqR5V1AVwhwJ82AESw1FKT/VBaYniZOQbO6Nfi5ZWz9F3s7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718648230; c=relaxed/simple; bh=xap048wXGPnkTeeUkyKZKOacBAvJpqsf4JNFpFJpobc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=btpBDtIE2uH/pumpqIdMgaGGgAM4g1b5Lp/eiYD1sA/hI3iHqUyTiCvuC0k21ozSGRgXos9TsFLqvAph33Jtx+4kmKUa4UzZEv77OTs0F0Pkuth4/1M9EfvFWOInk/OrmyOLD/9r7miBsMnXMAmCq80dMudvtUjgpQCIjZA7L7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lx6E3FcD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lx6E3FcD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98511C2BD10; Mon, 17 Jun 2024 18:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718648230; bh=xap048wXGPnkTeeUkyKZKOacBAvJpqsf4JNFpFJpobc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lx6E3FcD31LTO5UIdwGpbZSVnITiWEXHyFXYcI5lUehXiIqQeCKSBahY3ELKW5I7f H656Ng+wY+NqfFQoltMJ00pJkOtDWDKknE2oBpmWokCVyxR9++o/lUspv/QjDJo4a4 vabctBZvxZShtxJxM4kj3C3rhGhVI7S6R7rfn/JoMZT9L/Kr6v1qGX/e+bocF+UCPc /kAMjCFoajMxhsfdBNl3IZZ1WArjRvVBW7zQdwNO9KRWieJK3OvqfBJn41carACMJ6 SU5Qpm5NWKJlAk0rkOZ+3t6DCf+lYuJjVM6t2GaXm0O1HWckkxHpXEiAM4DERQJz4Y zhY+871d2gEYA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sJGuh-004iWw-Jr; Mon, 17 Jun 2024 19:17:08 +0100 Date: Mon, 17 Jun 2024 19:17:07 +0100 Message-ID: <86frtbjuxo.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , Zenghui Yu , kvm@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: nv: Use GFP_KERNEL_ACCOUNT for sysreg_masks allocation In-Reply-To: <20240617181018.2054332-1-oliver.upton@linux.dev> References: <20240617181018.2054332-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 17 Jun 2024 19:10:18 +0100, Oliver Upton wrote: > > Of course, userspace is in the driver's seat for struct kvm and > associated allocations. Make sure the sysreg_masks allocation > participates in kmem accounting. > > Signed-off-by: Oliver Upton > --- > arch/arm64/kvm/nested.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index 6813c7c7f00a..57e3fb3eb334 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -196,7 +196,7 @@ int kvm_init_nv_sysregs(struct kvm *kvm) > goto out; > > kvm->arch.sysreg_masks = kzalloc(sizeof(*(kvm->arch.sysreg_masks)), > - GFP_KERNEL); > + GFP_KERNEL_ACCOUNT); > if (!kvm->arch.sysreg_masks) { > ret = -ENOMEM; > goto out; > > base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 Ah, well spotted. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.